Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Side by Side Diff: third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.h

Issue 2258133002: [scheduler] Implement time-based cpu throttling. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: One more fix Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef THIRD_PARTY_WEBKIT_SOURCE_PLATFORM_SCHEDULER_RENDERER_THROTTLING_HELPER_ H_ 5 #ifndef THIRD_PARTY_WEBKIT_SOURCE_PLATFORM_SCHEDULER_RENDERER_THROTTLING_HELPER_ H_
6 #define THIRD_PARTY_WEBKIT_SOURCE_PLATFORM_SCHEDULER_RENDERER_THROTTLING_HELPER_ H_ 6 #define THIRD_PARTY_WEBKIT_SOURCE_PLATFORM_SCHEDULER_RENDERER_THROTTLING_HELPER_ H_
7 7
8 #include <set> 8 #include <set>
9 #include <unordered_map>
9 10
11 #include "base/logging.h"
10 #include "base/macros.h" 12 #include "base/macros.h"
13 #include "base/optional.h"
14 #include "base/threading/thread_checker.h"
11 #include "platform/scheduler/base/cancelable_closure_holder.h" 15 #include "platform/scheduler/base/cancelable_closure_holder.h"
12 #include "platform/scheduler/base/time_domain.h" 16 #include "platform/scheduler/base/time_domain.h"
13 #include "public/platform/WebViewScheduler.h" 17 #include "public/platform/WebViewScheduler.h"
14 18
15 namespace blink { 19 namespace blink {
16 namespace scheduler { 20 namespace scheduler {
17 21
18 class RendererSchedulerImpl; 22 class RendererSchedulerImpl;
19 class ThrottledTimeDomain; 23 class ThrottledTimeDomain;
20 class WebFrameSchedulerImpl; 24 class WebFrameSchedulerImpl;
21 25
22 // The job of the ThrottlingHelper is to run tasks posted on throttled queues at 26 // The job of the TaskQueueThrottler is to control when tasks posted on
23 // most once per second. This is done by disabling throttled queues and running 27 // throttled queues get run. The TaskQueueThrottler:
28 // - runs throttled tasks once per second,
29 // - controls time budget for task queues grouped in TimeBudgetPools.
30 //
31 // This is done by disabling throttled queues and running
24 // a special "heart beat" function |PumpThrottledTasks| which when run 32 // a special "heart beat" function |PumpThrottledTasks| which when run
25 // temporarily enables throttled queues and inserts a fence to ensure tasks 33 // temporarily enables throttled queues and inserts a fence to ensure tasks
26 // posted from a throttled task run next time the queue is pumped. 34 // posted from a throttled task run next time the queue is pumped.
27 // 35 //
28 // Of course the ThrottlingHelper isn't the only sub-system that wants to enable 36 // Of course the TaskQueueThrottler isn't the only sub-system that wants to
29 // or disable queues. E.g. RendererSchedulerImpl also does this for policy 37 // enable or disable queues. E.g. RendererSchedulerImpl also does this for
30 // reasons. To prevent the systems from fighting, clients of ThrottlingHelper 38 // policy reasons. To prevent the systems from fighting, clients of
31 // must use SetQueueEnabled rather than calling the function directly on the 39 // TaskQueueThrottler must use SetQueueEnabled rather than calling the function
32 // queue. 40 // directly on the queue.
33 // 41 //
34 // There may be more than one system that wishes to throttle a queue (e.g. 42 // There may be more than one system that wishes to throttle a queue (e.g.
35 // renderer suspension vs tab level suspension) so the ThrottlingHelper keeps a 43 // renderer suspension vs tab level suspension) so the TaskQueueThrottler keeps
36 // count of the number of systems that wish a queue to be throttled. 44 // a count of the number of systems that wish a queue to be throttled.
37 // See IncreaseThrottleRefCount & DecreaseThrottleRefCount. 45 // See IncreaseThrottleRefCount & DecreaseThrottleRefCount.
38 class BLINK_PLATFORM_EXPORT ThrottlingHelper : public TimeDomain::Observer { 46 //
47 // This class is main-thread only.
48 class BLINK_PLATFORM_EXPORT TaskQueueThrottler : public TimeDomain::Observer {
39 public: 49 public:
40 ThrottlingHelper(RendererSchedulerImpl* renderer_scheduler, 50 // TimeBudgetPool represents a group of task queues which share a limit
41 const char* tracing_category); 51 // on execution time. This limit applies when task queues are already
52 // throttled by TaskQueueThrottler.
53 class TimeBudgetPool {
54 public:
55 ~TimeBudgetPool();
42 56
43 ~ThrottlingHelper() override; 57 // Throttle task queues from this time budget pool if tasks are running
58 // for more than |cpu_percentage| per cent of wall time.
59 // This function does not affect internal time budget level.
60 void SetTimeBudget(base::TimeTicks now, double cpu_percentage);
61
62 // Adds |queue| to given pool. If the pool restriction does not allow
63 // a task to be run immediately and |queue| is throttled, |queue| becomes
64 // disabled.
65 void AddQueue(base::TimeTicks now, TaskQueue* queue);
66
67 // Removes |queue| from given pool. If it is throttled, it does not
68 // become enabled immediately, but a call to |PumpThrottledTasks|
69 // is scheduled.
70 void RemoveQueue(base::TimeTicks now, TaskQueue* queue);
71
72 void RecordTaskRunTime(base::TimeDelta task_run_time);
73
74 // Enables this time budget pool. Queues from this pool will be
75 // throttled based on their run time.
76 void EnableThrottling(LazyNow* now);
77
78 // Disables with time budget pool. Queues from this pool will not be
79 // throttled based on their run time. A call to |PumpThrottledTasks|
80 // will be scheduled to enable this queues back again and respect
81 // timer alignment. Internal budget level will not regenerate with time.
82 void DisableThrottling(LazyNow* now);
83
84 bool IsThrottlingEnabled() const;
85
86 const char* Name() const;
87
88 // All queues should be removed before calling Close().
89 void Close();
90
91 private:
92 friend class TaskQueueThrottler;
93
94 FRIEND_TEST_ALL_PREFIXES(TaskQueueThrottlerTest, TimeBudgetPool);
95
96 TimeBudgetPool(const char* name,
97 TaskQueueThrottler* task_queue_throttler,
98 base::TimeTicks now);
99
100 bool HasEnoughBudgetToRun(base::TimeTicks now);
101 base::TimeTicks GetNextAllowedRunTime();
102
103 // Advances |last_checkpoint_| to |now| if needed and recalculates
104 // budget level.
105 void Advance(base::TimeTicks now);
106
107 // Returns state for tracing.
108 void AsValueInto(base::trace_event::TracedValue* state,
109 base::TimeTicks now) const;
110
111 // Disable all associated throttled queues.
112 void BlockQueues(base::TimeTicks now);
Sami 2016/09/22 12:34:08 nit: BlockThrottledQueues?
altimin 2016/09/22 13:45:59 Done.
113
114 const char* name_; // NOT OWNED
115
116 TaskQueueThrottler* task_queue_throttler_;
117
118 base::TimeDelta current_budget_level_;
119 base::TimeDelta max_budget_level_;
120 base::TimeTicks last_checkpoint_;
121 double cpu_percentage_;
122 bool is_enabled_;
123
124 std::unordered_set<TaskQueue*> associated_task_queues_;
125
126 DISALLOW_COPY_AND_ASSIGN(TimeBudgetPool);
127 };
128
129 TaskQueueThrottler(RendererSchedulerImpl* renderer_scheduler,
130 const char* tracing_category);
131
132 ~TaskQueueThrottler() override;
44 133
45 // TimeDomain::Observer implementation: 134 // TimeDomain::Observer implementation:
46 void OnTimeDomainHasImmediateWork() override; 135 void OnTimeDomainHasImmediateWork(TaskQueue*) override;
47 void OnTimeDomainHasDelayedWork() override; 136 void OnTimeDomainHasDelayedWork(TaskQueue*) override;
48 137
49 // The purpose of this method is to make sure throttling doesn't conflict with 138 // The purpose of this method is to make sure throttling doesn't conflict with
50 // enabling/disabling the queue for policy reasons. 139 // enabling/disabling the queue for policy reasons.
51 // If |task_queue| is throttled then the ThrottlingHelper remembers the 140 // If |task_queue| is throttled then the TaskQueueThrottler remembers the
52 // |enabled| setting. In addition if |enabled| is false then the queue is 141 // |enabled| setting. In addition if |enabled| is false then the queue is
53 // immediatly disabled. Otherwise if |task_queue| not throttled then 142 // immediatly disabled. Otherwise if |task_queue| not throttled then
54 // TaskQueue::SetEnabled(enabled) is called. 143 // TaskQueue::SetEnabled(enabled) is called.
55 void SetQueueEnabled(TaskQueue* task_queue, bool enabled); 144 void SetQueueEnabled(TaskQueue* task_queue, bool enabled);
56 145
57 // Increments the throttled refcount and causes |task_queue| to be throttled 146 // Increments the throttled refcount and causes |task_queue| to be throttled
58 // if its not already throttled. 147 // if its not already throttled.
59 void IncreaseThrottleRefCount(TaskQueue* task_queue); 148 void IncreaseThrottleRefCount(TaskQueue* task_queue);
60 149
61 // If the refcouint is non-zero it's decremented. If the throttled refcount 150 // If the refcouint is non-zero it's decremented. If the throttled refcount
62 // becomes zero then |task_queue| is unthrottled. If the refcount was already 151 // becomes zero then |task_queue| is unthrottled. If the refcount was already
63 // zero this function does nothing. 152 // zero this function does nothing.
64 void DecreaseThrottleRefCount(TaskQueue* task_queue); 153 void DecreaseThrottleRefCount(TaskQueue* task_queue);
65 154
66 // Removes |task_queue| from |throttled_queues_|. 155 // Removes |task_queue| from |queue_details| and from appropriate budget pool.
67 void UnregisterTaskQueue(TaskQueue* task_queue); 156 void UnregisterTaskQueue(TaskQueue* task_queue);
68 157
69 // Returns true if the |task_queue| is throttled. 158 // Returns true if the |task_queue| is throttled.
70 bool IsThrottled(TaskQueue* task_queue) const; 159 bool IsThrottled(TaskQueue* task_queue) const;
71 160
72 // Tells the ThrottlingHelper we're using virtual time, which disables all 161 // Tells the TaskQueueThrottler we're using virtual time, which disables all
73 // throttling. 162 // throttling.
74 void EnableVirtualTime(); 163 void EnableVirtualTime();
75 164
76 const ThrottledTimeDomain* time_domain() const { return time_domain_.get(); } 165 const ThrottledTimeDomain* time_domain() const { return time_domain_.get(); }
77 166
78 static base::TimeTicks ThrottledRunTime(base::TimeTicks unthrottled_runtime); 167 static base::TimeTicks AlignedThrottledRunTime(
168 base::TimeTicks unthrottled_runtime);
79 169
80 const scoped_refptr<TaskQueue>& task_runner() const { return task_runner_; } 170 const scoped_refptr<TaskQueue>& task_runner() const { return task_runner_; }
81 171
172 // Returned object is owned by |TaskQueueThrottler|.
173 TimeBudgetPool* CreateTimeBudgetPool(const char* name);
174
175 // Accounts for given task for cpu-based throttling needs.
176 void OnTaskRunTimeReported(TaskQueue* task_queue,
177 base::TimeTicks start_time,
178 base::TimeTicks end_time);
179
180 void AsValueInto(base::trace_event::TracedValue* state,
181 base::TimeTicks now) const;
caseq 2016/09/22 00:52:34 Why do we need a timestamp for something that is d
altimin 2016/09/22 13:45:59 The most convenient way to write TimeTicks into tr
182
82 private: 183 private:
83 struct Metadata { 184 struct Metadata {
84 Metadata() : throttling_ref_count(0), enabled(false) {} 185 Metadata()
186 : throttling_ref_count(0), enabled(false), time_budget_pool(nullptr) {}
85 187
86 Metadata(size_t ref_count, bool is_enabled) 188 Metadata(size_t ref_count, bool is_enabled)
87 : throttling_ref_count(ref_count), enabled(is_enabled) {} 189 : throttling_ref_count(ref_count),
190 enabled(is_enabled),
191 time_budget_pool(nullptr) {}
88 192
89 size_t throttling_ref_count; 193 size_t throttling_ref_count;
90 bool enabled; 194 bool enabled;
195
196 TimeBudgetPool* time_budget_pool;
197
198 bool IsThrottled() const { return throttling_ref_count > 0; }
91 }; 199 };
92 using TaskQueueMap = std::map<TaskQueue*, Metadata>; 200 using TaskQueueMap = std::unordered_map<TaskQueue*, Metadata>;
93 201
94 void PumpThrottledTasks(); 202 void PumpThrottledTasks();
95 203
96 // Note |unthrottled_runtime| might be in the past. When this happens we 204 // Note |unthrottled_runtime| might be in the past. When this happens we
97 // compute the delay to the next runtime based on now rather than 205 // compute the delay to the next runtime based on now rather than
98 // unthrottled_runtime. 206 // unthrottled_runtime.
99 void MaybeSchedulePumpThrottledTasksLocked( 207 void MaybeSchedulePumpThrottledTasks(
100 const tracked_objects::Location& from_here, 208 const tracked_objects::Location& from_here,
101 base::TimeTicks now, 209 base::TimeTicks now,
102 base::TimeTicks unthrottled_runtime); 210 base::TimeTicks runtime);
103 211
104 TaskQueueMap throttled_queues_; 212 TimeBudgetPool* GetTimeBudgetPoolForQueue(TaskQueue* queue);
105 base::Closure forward_immediate_work_closure_; 213
214 // Schedule pumping because of given task queue.
215 void MaybeSchedulePumpQueue(
216 const tracked_objects::Location& from_here,
217 base::TimeTicks now,
218 TaskQueue* queue,
219 base::Optional<base::TimeTicks> next_possible_run_time);
220
221 // Return next possible time when queue is allowed to run in accordance
222 // with throttling policy.
223 base::TimeTicks GetNextAllowedRunTime(base::TimeTicks now, TaskQueue* queue);
224
225 void MaybeDeleteQueueMetadata(TaskQueueMap::iterator it);
226
227 TaskQueueMap queue_details_;
228 base::Callback<void(TaskQueue*)> forward_immediate_work_callback_;
106 scoped_refptr<TaskQueue> task_runner_; 229 scoped_refptr<TaskQueue> task_runner_;
107 RendererSchedulerImpl* renderer_scheduler_; // NOT OWNED 230 RendererSchedulerImpl* renderer_scheduler_; // NOT OWNED
108 base::TickClock* tick_clock_; // NOT OWNED 231 base::TickClock* tick_clock_; // NOT OWNED
109 const char* tracing_category_; // NOT OWNED 232 const char* tracing_category_; // NOT OWNED
110 std::unique_ptr<ThrottledTimeDomain> time_domain_; 233 std::unique_ptr<ThrottledTimeDomain> time_domain_;
111 234
112 CancelableClosureHolder pump_throttled_tasks_closure_; 235 CancelableClosureHolder pump_throttled_tasks_closure_;
113 base::TimeTicks pending_pump_throttled_tasks_runtime_; 236 base::Optional<base::TimeTicks> pending_pump_throttled_tasks_runtime_;
114 bool virtual_time_; 237 bool virtual_time_;
115 238
116 base::WeakPtrFactory<ThrottlingHelper> weak_factory_; 239 std::unordered_map<TimeBudgetPool*, std::unique_ptr<TimeBudgetPool>>
240 time_budget_pools_;
117 241
118 DISALLOW_COPY_AND_ASSIGN(ThrottlingHelper); 242 base::WeakPtrFactory<TaskQueueThrottler> weak_factory_;
243
244 DISALLOW_COPY_AND_ASSIGN(TaskQueueThrottler);
119 }; 245 };
120 246
121 } // namespace scheduler 247 } // namespace scheduler
122 } // namespace blink 248 } // namespace blink
123 249
124 #endif // THIRD_PARTY_WEBKIT_SOURCE_PLATFORM_SCHEDULER_RENDERER_THROTTLING_HELP ER_H_ 250 #endif // THIRD_PARTY_WEBKIT_SOURCE_PLATFORM_SCHEDULER_RENDERER_THROTTLING_HELP ER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698