Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 225813008: Change regex back to wildcard match. (Closed)

Created:
6 years, 8 months ago by Yaron
Modified:
6 years, 8 months ago
Reviewers:
nyquist
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Change regex back to wildcard match. Apparently gtest doesn't support [] in regexs. While it can match too much, for the given input page, it's correct. BUG=353349 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263052

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M components/dom_distiller/content/distiller_page_web_contents_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Yaron
6 years, 8 months ago (2014-04-10 17:20:41 UTC) #1
nyquist
lgtm
6 years, 8 months ago (2014-04-10 17:21:26 UTC) #2
Yaron
The CQ bit was checked by yfriedman@chromium.org
6 years, 8 months ago (2014-04-10 17:25:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/225813008/1
6 years, 8 months ago (2014-04-10 17:25:57 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-10 19:34:57 UTC) #5
Message was sent while issue was closed.
Change committed as 263052

Powered by Google App Engine
This is Rietveld 408576698