Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 22581002: Use EventHandler type instead of EventListener for event handler attributes (Closed)

Created:
7 years, 4 months ago by do-not-use
Modified:
7 years, 4 months ago
CC:
blink-reviews, eae+blinkwatch, dgrogan, adamk+blink_chromium.org, pdr, Nils Barth (inactive), Nate Chapin, alecflett, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, kinuko, feature-media-reviews_chromium.org, tommyw+watchlist_chromium.org, darktears, kojih, vcarbune.chromium, jsbell, jsbell+bindings_chromium.org, f(malita), apavlov+blink_chromium.org, Stephen Chennney, lgombos
Visibility:
Public.

Description

Use EventHandler type instead of EventListener for event handler attributes Distinguish in the IDL the HTML EventHandler attributes and DOM EventListener types added via addEventListener() method to match the specifications: http://www.whatwg.org/specs/web-apps/current-work/multipage/webappapis.html#eventhandler http://dom.spec.whatwg.org/#eventlistener This makes our IDL closer to the specifications but there is no web-exposed behavior change with this patch. In the future, however, we may consider supporting only JS Functions (not objects with handleEvent() method) as input for EventHandler attributes to match the specification. R=haraken Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155702

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+459 lines, -458 lines) Patch
M Source/bindings/scripts/deprecated_code_generator_v8.pm View 9 chunks +10 lines, -9 lines 0 comments Download
M Source/bindings/tests/idls/TestObject.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestObject.cpp View 2 chunks +11 lines, -11 lines 0 comments Download
M Source/core/css/FontLoader.idl View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/dom/Document.idl View 1 chunk +74 lines, -74 lines 0 comments Download
M Source/core/dom/Element.idl View 1 chunk +70 lines, -70 lines 0 comments Download
M Source/core/dom/MessagePort.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fileapi/FileReader.idl View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/html/HTMLBodyElement.idl View 1 chunk +18 lines, -18 lines 0 comments Download
M Source/core/html/HTMLFormElement.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLFrameSetElement.idl View 1 chunk +18 lines, -18 lines 0 comments Download
M Source/core/html/HTMLInputElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLMarqueeElement.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLMediaElement.idl View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/html/track/TextTrack.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/track/TextTrackCue.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/track/TextTrackList.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/appcache/DOMApplicationCache.idl View 1 chunk +8 lines, -8 lines 0 comments Download
M Source/core/page/EventSource.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/page/Performance.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/Window.idl View 1 chunk +84 lines, -84 lines 0 comments Download
M Source/core/svg/SVGElementInstance.idl View 1 chunk +42 lines, -42 lines 0 comments Download
M Source/core/workers/AbstractWorker.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/DedicatedWorkerGlobalScope.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/SharedWorkerGlobalScope.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/Worker.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/WorkerGlobalScope.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XMLHttpRequest.idl View 1 chunk +8 lines, -8 lines 0 comments Download
M Source/core/xml/XMLHttpRequestUpload.idl View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/modules/encryptedmedia/MediaKeySession.idl View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/modules/filesystem/FileWriter.idl View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/modules/indexeddb/IDBDatabase.idl View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/modules/indexeddb/IDBOpenDBRequest.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/indexeddb/IDBRequest.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/indexeddb/IDBTransaction.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/mediastream/MediaStream.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/mediastream/MediaStreamTrack.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/mediastream/RTCDTMFSender.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediastream/RTCDataChannel.idl View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/modules/mediastream/RTCPeerConnection.idl View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/modules/notifications/Notification.idl View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/modules/speech/SpeechRecognition.idl View 1 chunk +11 lines, -11 lines 0 comments Download
M Source/modules/speech/SpeechSynthesisUtterance.idl View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/modules/webaudio/AudioBufferSourceNode.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/AudioContext.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/OscillatorNode.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/ScriptProcessorNode.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webmidi/MIDIAccess.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webmidi/MIDIInput.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webmidi/MIDIPort.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/websockets/WebSocket.idl View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
do-not-use
7 years, 4 months ago (2013-08-07 12:38:03 UTC) #1
haraken
LGTM
7 years, 4 months ago (2013-08-07 12:47:38 UTC) #2
arv (Not doing code reviews)
LGTM WOW, I didn't know we allowed something as crazy broken as: document.onclick = { ...
7 years, 4 months ago (2013-08-07 13:35:10 UTC) #3
do-not-use
On 2013/08/07 13:35:10, arv wrote: > LGTM > > WOW, I didn't know we allowed ...
7 years, 4 months ago (2013-08-07 13:40:21 UTC) #4
arv (Not doing code reviews)
On 2013/08/07 13:40:21, Christophe Dumez wrote: > On 2013/08/07 13:35:10, arv wrote: > > LGTM ...
7 years, 4 months ago (2013-08-07 14:01:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/22581002/1
7 years, 4 months ago (2013-08-07 16:32:40 UTC) #6
commit-bot: I haz the power
7 years, 4 months ago (2013-08-07 18:19:44 UTC) #7
Message was sent while issue was closed.
Change committed as 155702

Powered by Google App Engine
This is Rietveld 408576698