Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2258093002: MIPS64: Fix [wasm] Support validation of asm.js modules with != 3 args. (Closed)

Created:
4 years, 4 months ago by ivica.bogosavljevic
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, bradnelson
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: Fix [wasm] Support validation of asm.js modules with != 3 args. Fix d0e52555f07a6f01a25114355007bc9095e00f6a Typo in builtin-mips64.cc caused crashes in test mjsunit/asm/asm-validation.js TEST=mjsunit/asm/asm-validation BUG= Committed: https://crrev.com/9092f8ac869f91db4eb5615a1c2ddc51f6a58098 Cr-Commit-Position: refs/heads/master@{#38757}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/builtins/mips64/builtins-mips64.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
ivica.bogosavljevic
PTAL
4 years, 4 months ago (2016-08-19 12:58:56 UTC) #2
akos.palfi.imgtec
Lgtm
4 years, 4 months ago (2016-08-19 13:59:56 UTC) #3
bradnelson
lgtm Ah, indeed, that was off. Thanks!
4 years, 4 months ago (2016-08-19 14:08:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2258093002/1
4 years, 4 months ago (2016-08-19 14:08:48 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-19 15:26:20 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 15:26:42 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9092f8ac869f91db4eb5615a1c2ddc51f6a58098
Cr-Commit-Position: refs/heads/master@{#38757}

Powered by Google App Engine
This is Rietveld 408576698