src/compiler/simplified-lowering.cc - Issue 2258073002: [Turbofan]: Use new MachineTypes in access-builder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/simplified-lowering.cc

Issue 2258073002: [Turbofan]: Use new MachineTypes in access-builder. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Code comments addressed. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/simplified-lowering.cc

diff --git a/src/compiler/simplified-lowering.cc b/src/compiler/simplified-lowering.cc

index d886cf02a702a9b69e4c2c573e6b08be62f6e597..e1f5b0b5b1929894cef318a2bc810eb8fbdda7b2 100644

--- a/src/compiler/simplified-lowering.cc

+++ b/src/compiler/simplified-lowering.cc

@@ -1031,7 +1031,8 @@ class RepresentationSelector {

MachineRepresentation field_representation, Type* field_type,

Node* value) {

if (base_taggedness == kTaggedBase &&

- field_representation == MachineRepresentation::kTagged) {

+ (field_representation == MachineRepresentation::kTagged ||

+ field_representation == MachineRepresentation::kTaggedPointer)) {

Type* value_type = NodeProperties::GetType(value);

if (field_type->Is(Type::TaggedSigned()) ||

value_type->Is(Type::TaggedSigned())) {