Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Unified Diff: src/compiler/register-allocator.cc

Issue 2258073002: [Turbofan]: Use new MachineTypes in access-builder. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Code comments addressed. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/compiler/register-allocator.cc
diff --git a/src/compiler/register-allocator.cc b/src/compiler/register-allocator.cc
index 5b55b0224c6debc7148a150c1bbe73d6011ee488..e9da735d2c14a703627712465b5c13c47a3f2958 100644
--- a/src/compiler/register-allocator.cc
+++ b/src/compiler/register-allocator.cc
@@ -3273,8 +3273,10 @@ void ReferenceMapPopulator::PopulateReferenceMaps() {
spill_operand = range->GetSpillRangeOperand();
}
DCHECK(spill_operand.IsStackSlot());
- DCHECK_EQ(MachineRepresentation::kTagged,
- AllocatedOperand::cast(spill_operand).representation());
+ DCHECK(AllocatedOperand::cast(spill_operand).representation() ==
+ MachineRepresentation::kTagged ||
+ AllocatedOperand::cast(spill_operand).representation() ==
+ MachineRepresentation::kTaggedPointer);
}
LiveRange* cur = range;
@@ -3336,8 +3338,10 @@ void ReferenceMapPopulator::PopulateReferenceMaps() {
safe_point);
InstructionOperand operand = cur->GetAssignedOperand();
DCHECK(!operand.IsStackSlot());
- DCHECK_EQ(MachineRepresentation::kTagged,
- AllocatedOperand::cast(operand).representation());
+ DCHECK(AllocatedOperand::cast(operand).representation() ==
+ MachineRepresentation::kTagged ||
+ AllocatedOperand::cast(operand).representation() ==
+ MachineRepresentation::kTaggedPointer);
map->RecordReference(AllocatedOperand::cast(operand));
}
}

Powered by Google App Engine
This is Rietveld 408576698