src/compiler/x64/instruction-selector-x64.cc - Issue 2258073002: [Turbofan]: Use new MachineTypes in access-builder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/x64/instruction-selector-x64.cc

Issue 2258073002: [Turbofan]: Use new MachineTypes in access-builder. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fixed write barrier issue. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/x64/instruction-selector-x64.cc

diff --git a/src/compiler/x64/instruction-selector-x64.cc b/src/compiler/x64/instruction-selector-x64.cc

index 9f0adbc9afea1c70b415da410b3d439b381083a9..047854af1689e25f20cf98108850f0eb74985330 100644

--- a/src/compiler/x64/instruction-selector-x64.cc

+++ b/src/compiler/x64/instruction-selector-x64.cc

@@ -212,7 +212,8 @@ void InstructionSelector::VisitStore(Node* node) {

MachineRepresentation rep = store_rep.representation();

if (write_barrier_kind != kNoWriteBarrier) {

- DCHECK_EQ(MachineRepresentation::kTagged, rep);

+ DCHECK(rep == MachineRepresentation::kTagged ||

+ rep == MachineRepresentation::kTaggedPointer);

AddressingMode addressing_mode;

InstructionOperand inputs[3];

size_t input_count = 0;