Chromium Code Reviews

Unified Diff: src/compiler/mips64/instruction-selector-mips64.cc

Issue 2258073002: [Turbofan]: Use new MachineTypes in access-builder. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fixed write barrier issue. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
« src/compiler/arm/instruction-selector-arm.cc ('K') | « src/compiler/mips/instruction-selector-mips.cc ('k') | src/compiler/opcodes.h » ('j') | src/compiler/representation-change.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/mips64/instruction-selector-mips64.cc
diff --git a/src/compiler/mips64/instruction-selector-mips64.cc b/src/compiler/mips64/instruction-selector-mips64.cc
index 60790b51b220e6fafa7821fd2bcb2097a62aa2fb..d517699426324de441eedaaa3077c6027c2346c1 100644
--- a/src/compiler/mips64/instruction-selector-mips64.cc
+++ b/src/compiler/mips64/instruction-selector-mips64.cc
@@ -205,7 +205,8 @@ void InstructionSelector::VisitStore(Node* node) {
// TODO(mips): I guess this could be done in a better way.
if (write_barrier_kind != kNoWriteBarrier) {
- DCHECK_EQ(MachineRepresentation::kTagged, rep);
+ DCHECK(rep == MachineRepresentation::kTagged ||
+ rep == MachineRepresentation::kTaggedPointer);
InstructionOperand inputs[3];
size_t input_count = 0;
inputs[input_count++] = g.UseUniqueRegister(base);
« src/compiler/arm/instruction-selector-arm.cc ('K') | « src/compiler/mips/instruction-selector-mips.cc ('k') | src/compiler/opcodes.h » ('j') | src/compiler/representation-change.cc » ('J')

Powered by Google App Engine