Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(756)

Side by Side Diff: src/compiler/mips/instruction-selector-mips.cc

Issue 2258073002: [Turbofan]: Use new MachineTypes in access-builder. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: A bit of refactoring. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/machine-operator.cc ('k') | src/compiler/mips64/instruction-selector-mips64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/base/adapters.h" 5 #include "src/base/adapters.h"
6 #include "src/base/bits.h" 6 #include "src/base/bits.h"
7 #include "src/compiler/instruction-selector-impl.h" 7 #include "src/compiler/instruction-selector-impl.h"
8 #include "src/compiler/node-matchers.h" 8 #include "src/compiler/node-matchers.h"
9 #include "src/compiler/node-properties.h" 9 #include "src/compiler/node-properties.h"
10 10
(...skipping 180 matching lines...) Expand 10 before | Expand all | Expand 10 after
191 Node* base = node->InputAt(0); 191 Node* base = node->InputAt(0);
192 Node* index = node->InputAt(1); 192 Node* index = node->InputAt(1);
193 Node* value = node->InputAt(2); 193 Node* value = node->InputAt(2);
194 194
195 StoreRepresentation store_rep = StoreRepresentationOf(node->op()); 195 StoreRepresentation store_rep = StoreRepresentationOf(node->op());
196 WriteBarrierKind write_barrier_kind = store_rep.write_barrier_kind(); 196 WriteBarrierKind write_barrier_kind = store_rep.write_barrier_kind();
197 MachineRepresentation rep = store_rep.representation(); 197 MachineRepresentation rep = store_rep.representation();
198 198
199 // TODO(mips): I guess this could be done in a better way. 199 // TODO(mips): I guess this could be done in a better way.
200 if (write_barrier_kind != kNoWriteBarrier) { 200 if (write_barrier_kind != kNoWriteBarrier) {
201 DCHECK_EQ(MachineRepresentation::kTagged, rep); 201 DCHECK(CanBeTaggedPointer(rep));
202 InstructionOperand inputs[3]; 202 InstructionOperand inputs[3];
203 size_t input_count = 0; 203 size_t input_count = 0;
204 inputs[input_count++] = g.UseUniqueRegister(base); 204 inputs[input_count++] = g.UseUniqueRegister(base);
205 inputs[input_count++] = g.UseUniqueRegister(index); 205 inputs[input_count++] = g.UseUniqueRegister(index);
206 inputs[input_count++] = g.UseUniqueRegister(value); 206 inputs[input_count++] = g.UseUniqueRegister(value);
207 RecordWriteMode record_write_mode = RecordWriteMode::kValueIsAny; 207 RecordWriteMode record_write_mode = RecordWriteMode::kValueIsAny;
208 switch (write_barrier_kind) { 208 switch (write_barrier_kind) {
209 case kNoWriteBarrier: 209 case kNoWriteBarrier:
210 UNREACHABLE(); 210 UNREACHABLE();
211 break; 211 break;
(...skipping 1446 matching lines...) Expand 10 before | Expand all | Expand 10 after
1658 DCHECK(IsMipsArchVariant(kLoongson) || IsMipsArchVariant(kMips32r1) || 1658 DCHECK(IsMipsArchVariant(kLoongson) || IsMipsArchVariant(kMips32r1) ||
1659 IsMipsArchVariant(kMips32r2)); 1659 IsMipsArchVariant(kMips32r2));
1660 return MachineOperatorBuilder::AlignmentRequirements:: 1660 return MachineOperatorBuilder::AlignmentRequirements::
1661 NoUnalignedAccessSupport(); 1661 NoUnalignedAccessSupport();
1662 } 1662 }
1663 } 1663 }
1664 1664
1665 } // namespace compiler 1665 } // namespace compiler
1666 } // namespace internal 1666 } // namespace internal
1667 } // namespace v8 1667 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/machine-operator.cc ('k') | src/compiler/mips64/instruction-selector-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698