Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Side by Side Diff: src/compiler/arm/instruction-selector-arm.cc

Issue 2258073002: [Turbofan]: Use new MachineTypes in access-builder. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: A bit of refactoring. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/access-builder.cc ('k') | src/compiler/arm64/instruction-selector-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/base/adapters.h" 5 #include "src/base/adapters.h"
6 #include "src/base/bits.h" 6 #include "src/base/bits.h"
7 #include "src/compiler/instruction-selector-impl.h" 7 #include "src/compiler/instruction-selector-impl.h"
8 #include "src/compiler/node-matchers.h" 8 #include "src/compiler/node-matchers.h"
9 #include "src/compiler/node-properties.h" 9 #include "src/compiler/node-properties.h"
10 10
(...skipping 406 matching lines...) Expand 10 before | Expand all | Expand 10 after
417 ArmOperandGenerator g(this); 417 ArmOperandGenerator g(this);
418 Node* base = node->InputAt(0); 418 Node* base = node->InputAt(0);
419 Node* index = node->InputAt(1); 419 Node* index = node->InputAt(1);
420 Node* value = node->InputAt(2); 420 Node* value = node->InputAt(2);
421 421
422 StoreRepresentation store_rep = StoreRepresentationOf(node->op()); 422 StoreRepresentation store_rep = StoreRepresentationOf(node->op());
423 WriteBarrierKind write_barrier_kind = store_rep.write_barrier_kind(); 423 WriteBarrierKind write_barrier_kind = store_rep.write_barrier_kind();
424 MachineRepresentation rep = store_rep.representation(); 424 MachineRepresentation rep = store_rep.representation();
425 425
426 if (write_barrier_kind != kNoWriteBarrier) { 426 if (write_barrier_kind != kNoWriteBarrier) {
427 DCHECK_EQ(MachineRepresentation::kTagged, rep); 427 DCHECK(CanBeTaggedPointer(rep));
428 AddressingMode addressing_mode; 428 AddressingMode addressing_mode;
429 InstructionOperand inputs[3]; 429 InstructionOperand inputs[3];
430 size_t input_count = 0; 430 size_t input_count = 0;
431 inputs[input_count++] = g.UseUniqueRegister(base); 431 inputs[input_count++] = g.UseUniqueRegister(base);
432 // OutOfLineRecordWrite uses the index in an 'add' instruction as well as 432 // OutOfLineRecordWrite uses the index in an 'add' instruction as well as
433 // for the store itself, so we must check compatibility with both. 433 // for the store itself, so we must check compatibility with both.
434 if (g.CanBeImmediate(index, kArmAdd) && g.CanBeImmediate(index, kArmStr)) { 434 if (g.CanBeImmediate(index, kArmAdd) && g.CanBeImmediate(index, kArmStr)) {
435 inputs[input_count++] = g.UseImmediate(index); 435 inputs[input_count++] = g.UseImmediate(index);
436 addressing_mode = kMode_Offset_RI; 436 addressing_mode = kMode_Offset_RI;
437 } else { 437 } else {
(...skipping 1821 matching lines...) Expand 10 before | Expand all | Expand 10 after
2259 Vector<MachineType> req_aligned = Vector<MachineType>::New(2); 2259 Vector<MachineType> req_aligned = Vector<MachineType>::New(2);
2260 req_aligned[0] = MachineType::Float32(); 2260 req_aligned[0] = MachineType::Float32();
2261 req_aligned[1] = MachineType::Float64(); 2261 req_aligned[1] = MachineType::Float64();
2262 return MachineOperatorBuilder::AlignmentRequirements:: 2262 return MachineOperatorBuilder::AlignmentRequirements::
2263 SomeUnalignedAccessUnsupported(req_aligned, req_aligned); 2263 SomeUnalignedAccessUnsupported(req_aligned, req_aligned);
2264 } 2264 }
2265 2265
2266 } // namespace compiler 2266 } // namespace compiler
2267 } // namespace internal 2267 } // namespace internal
2268 } // namespace v8 2268 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/access-builder.cc ('k') | src/compiler/arm64/instruction-selector-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698