Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(794)

Side by Side Diff: src/compiler/mips64/instruction-selector-mips64.cc

Issue 2258073002: [Turbofan]: Use new MachineTypes in access-builder. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fixed write barrier issue. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/base/adapters.h" 5 #include "src/base/adapters.h"
6 #include "src/base/bits.h" 6 #include "src/base/bits.h"
7 #include "src/compiler/instruction-selector-impl.h" 7 #include "src/compiler/instruction-selector-impl.h"
8 #include "src/compiler/node-matchers.h" 8 #include "src/compiler/node-matchers.h"
9 #include "src/compiler/node-properties.h" 9 #include "src/compiler/node-properties.h"
10 10
(...skipping 187 matching lines...) Expand 10 before | Expand all | Expand 10 after
198 Node* base = node->InputAt(0); 198 Node* base = node->InputAt(0);
199 Node* index = node->InputAt(1); 199 Node* index = node->InputAt(1);
200 Node* value = node->InputAt(2); 200 Node* value = node->InputAt(2);
201 201
202 StoreRepresentation store_rep = StoreRepresentationOf(node->op()); 202 StoreRepresentation store_rep = StoreRepresentationOf(node->op());
203 WriteBarrierKind write_barrier_kind = store_rep.write_barrier_kind(); 203 WriteBarrierKind write_barrier_kind = store_rep.write_barrier_kind();
204 MachineRepresentation rep = store_rep.representation(); 204 MachineRepresentation rep = store_rep.representation();
205 205
206 // TODO(mips): I guess this could be done in a better way. 206 // TODO(mips): I guess this could be done in a better way.
207 if (write_barrier_kind != kNoWriteBarrier) { 207 if (write_barrier_kind != kNoWriteBarrier) {
208 DCHECK_EQ(MachineRepresentation::kTagged, rep); 208 DCHECK(rep == MachineRepresentation::kTagged ||
209 rep == MachineRepresentation::kTaggedPointer);
209 InstructionOperand inputs[3]; 210 InstructionOperand inputs[3];
210 size_t input_count = 0; 211 size_t input_count = 0;
211 inputs[input_count++] = g.UseUniqueRegister(base); 212 inputs[input_count++] = g.UseUniqueRegister(base);
212 inputs[input_count++] = g.UseUniqueRegister(index); 213 inputs[input_count++] = g.UseUniqueRegister(index);
213 inputs[input_count++] = g.UseUniqueRegister(value); 214 inputs[input_count++] = g.UseUniqueRegister(value);
214 RecordWriteMode record_write_mode = RecordWriteMode::kValueIsAny; 215 RecordWriteMode record_write_mode = RecordWriteMode::kValueIsAny;
215 switch (write_barrier_kind) { 216 switch (write_barrier_kind) {
216 case kNoWriteBarrier: 217 case kNoWriteBarrier:
217 UNREACHABLE(); 218 UNREACHABLE();
218 break; 219 break;
(...skipping 1940 matching lines...) Expand 10 before | Expand all | Expand 10 after
2159 } else { 2160 } else {
2160 DCHECK(kArchVariant == kMips64r2); 2161 DCHECK(kArchVariant == kMips64r2);
2161 return MachineOperatorBuilder::AlignmentRequirements:: 2162 return MachineOperatorBuilder::AlignmentRequirements::
2162 NoUnalignedAccessSupport(); 2163 NoUnalignedAccessSupport();
2163 } 2164 }
2164 } 2165 }
2165 2166
2166 } // namespace compiler 2167 } // namespace compiler
2167 } // namespace internal 2168 } // namespace internal
2168 } // namespace v8 2169 } // namespace v8
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698