Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Side by Side Diff: src/compiler/ia32/instruction-selector-ia32.cc

Issue 2258073002: [Turbofan]: Use new MachineTypes in access-builder. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fixed write barrier issue. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/base/adapters.h" 5 #include "src/base/adapters.h"
6 #include "src/compiler/instruction-selector-impl.h" 6 #include "src/compiler/instruction-selector-impl.h"
7 #include "src/compiler/node-matchers.h" 7 #include "src/compiler/node-matchers.h"
8 #include "src/compiler/node-properties.h" 8 #include "src/compiler/node-properties.h"
9 9
10 namespace v8 { 10 namespace v8 {
(...skipping 244 matching lines...) Expand 10 before | Expand all | Expand 10 after
255 IA32OperandGenerator g(this); 255 IA32OperandGenerator g(this);
256 Node* base = node->InputAt(0); 256 Node* base = node->InputAt(0);
257 Node* index = node->InputAt(1); 257 Node* index = node->InputAt(1);
258 Node* value = node->InputAt(2); 258 Node* value = node->InputAt(2);
259 259
260 StoreRepresentation store_rep = StoreRepresentationOf(node->op()); 260 StoreRepresentation store_rep = StoreRepresentationOf(node->op());
261 WriteBarrierKind write_barrier_kind = store_rep.write_barrier_kind(); 261 WriteBarrierKind write_barrier_kind = store_rep.write_barrier_kind();
262 MachineRepresentation rep = store_rep.representation(); 262 MachineRepresentation rep = store_rep.representation();
263 263
264 if (write_barrier_kind != kNoWriteBarrier) { 264 if (write_barrier_kind != kNoWriteBarrier) {
265 DCHECK_EQ(MachineRepresentation::kTagged, rep); 265 DCHECK(rep == MachineRepresentation::kTagged ||
266 rep == MachineRepresentation::kTaggedPointer);
266 AddressingMode addressing_mode; 267 AddressingMode addressing_mode;
267 InstructionOperand inputs[3]; 268 InstructionOperand inputs[3];
268 size_t input_count = 0; 269 size_t input_count = 0;
269 inputs[input_count++] = g.UseUniqueRegister(base); 270 inputs[input_count++] = g.UseUniqueRegister(base);
270 if (g.CanBeImmediate(index)) { 271 if (g.CanBeImmediate(index)) {
271 inputs[input_count++] = g.UseImmediate(index); 272 inputs[input_count++] = g.UseImmediate(index);
272 addressing_mode = kMode_MRI; 273 addressing_mode = kMode_MRI;
273 } else { 274 } else {
274 inputs[input_count++] = g.UseUniqueRegister(index); 275 inputs[input_count++] = g.UseUniqueRegister(index);
275 addressing_mode = kMode_MR1; 276 addressing_mode = kMode_MR1;
(...skipping 1423 matching lines...) Expand 10 before | Expand all | Expand 10 after
1699 // static 1700 // static
1700 MachineOperatorBuilder::AlignmentRequirements 1701 MachineOperatorBuilder::AlignmentRequirements
1701 InstructionSelector::AlignmentRequirements() { 1702 InstructionSelector::AlignmentRequirements() {
1702 return MachineOperatorBuilder::AlignmentRequirements:: 1703 return MachineOperatorBuilder::AlignmentRequirements::
1703 FullUnalignedAccessSupport(); 1704 FullUnalignedAccessSupport();
1704 } 1705 }
1705 1706
1706 } // namespace compiler 1707 } // namespace compiler
1707 } // namespace internal 1708 } // namespace internal
1708 } // namespace v8 1709 } // namespace v8
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698