Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2258053003: Avoid signed overflow in CPDF_ToUnicodeMap::StringToCode() (Closed)

Created:
4 years, 4 months ago by Tom Sepez
Modified:
4 years, 4 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Avoid signed overflow in CPDF_ToUnicodeMap::StringToCode() It was intended to be unsigned in the first place, and we're perfectly happy with the overflow as long as it is no longer undefined behaviour. BUG=638489 Committed: https://pdfium.googlesource.com/pdfium/+/68624257bf300036a3898015eee718a6026ca6f5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M core/fpdfapi/fpdf_font/fpdf_font.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Tom Sepez
Lei, quick review.
4 years, 4 months ago (2016-08-19 22:23:08 UTC) #4
Lei Zhang
lgtm
4 years, 4 months ago (2016-08-19 22:33:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2258053003/1
4 years, 4 months ago (2016-08-19 22:40:20 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 22:48:08 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/68624257bf300036a3898015eee718a6026c...

Powered by Google App Engine
This is Rietveld 408576698