Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2237)

Issue 2258043002: Update remove non-owner user warning message and fix the unwanted space (Closed)

Created:
4 years, 4 months ago by Qiang(Joe) Xu
Modified:
4 years, 4 months ago
Reviewers:
Alexander Alekseev
CC:
chromium-reviews, dzhioev+watch_chromium.org, achuith+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update remove non-owner user warning message and fix the unwanted space Update the warning message using: "All files and local data associated with this user will be permanently deleted once this user is removed. user.email@gmail.com can still sign in later" Fix unwanted space on above warning message. BUG=611904 BUG=636711 TEST=desktop build test Committed: https://crrev.com/21f9b1fc35bfaab1d900d8c5fde3beb2a8eebdd8 Cr-Commit-Position: refs/heads/master@{#413160}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -6 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M ui/login/account_picker/user_pod_row.js View 6 chunks +24 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
Qiang(Joe) Xu
Hi Alexander, could you help review on this? Thanks!
4 years, 4 months ago (2016-08-19 06:55:50 UTC) #5
Alexander Alekseev
lgtm
4 years, 4 months ago (2016-08-19 08:40:40 UTC) #8
Alexander Alekseev
On 2016/08/19 08:40:40, Alexander Alekseev wrote: > lgtm nit: please format commit message body to ...
4 years, 4 months ago (2016-08-19 08:41:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2258043002/1
4 years, 4 months ago (2016-08-19 16:12:57 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-19 16:16:55 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 16:22:59 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/21f9b1fc35bfaab1d900d8c5fde3beb2a8eebdd8
Cr-Commit-Position: refs/heads/master@{#413160}

Powered by Google App Engine
This is Rietveld 408576698