third_party/WebKit/Source/core/html/URLRegistry.h - Issue 2258033002: Replace ASSERT()s with DCHECK*() in core/html/*.{cpp,h}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/URLRegistry.h

Issue 2258033002: Replace ASSERT()s with DCHECK*() in core/html/*.{cpp,h}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Replace ASSERT()s with DCHECK*() in core/html/*.{cpp,h}. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/TimeRanges.cpp ('k') | third_party/WebKit/Source/core/html/WindowNameCollection.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/URLRegistry.h

diff --git a/third_party/WebKit/Source/core/html/URLRegistry.h b/third_party/WebKit/Source/core/html/URLRegistry.h

index 77e94e0cb8c8c2be8c1bc4de8eb6bee05c76c0b3..63e7b53fa8e2e5f119f73118d2c208c9ecf140b8 100644

--- a/third_party/WebKit/Source/core/html/URLRegistry.h

+++ b/third_party/WebKit/Source/core/html/URLRegistry.h

@@ -54,8 +54,8 @@ public:

virtual void unregisterURL(const KURL&) = 0;

// These are optional APIs

- virtual URLRegistrable* lookup(const String&) { ASSERT_NOT_REACHED(); return nullptr; }

- virtual bool contains(const String&) { ASSERT_NOT_REACHED(); return false; }

+ virtual URLRegistrable* lookup(const String&) { NOTREACHED(); return nullptr; }

+ virtual bool contains(const String&) { NOTREACHED(); return false; }

};

} // namespace blink

« no previous file with comments | « third_party/WebKit/Source/core/html/TimeRanges.cpp ('k') | third_party/WebKit/Source/core/html/WindowNameCollection.h » ('j') | no next file with comments »