third_party/WebKit/Source/core/html/RadioNodeList.cpp - Issue 2258033002: Replace ASSERT()s with DCHECK*() in core/html/*.{cpp,h}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/RadioNodeList.cpp

Issue 2258033002: Replace ASSERT()s with DCHECK*() in core/html/*.{cpp,h}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Replace ASSERT()s with DCHECK*() in core/html/*.{cpp,h}. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/html/RadioNodeList.cpp

diff --git a/third_party/WebKit/Source/core/html/RadioNodeList.cpp b/third_party/WebKit/Source/core/html/RadioNodeList.cpp

index c05799cdbeb9fd78961e001c84e9d14843438cb9..acbdcc23701cc514d718fa1dbe00e86e78bbdb08 100644

--- a/third_party/WebKit/Source/core/html/RadioNodeList.cpp

+++ b/third_party/WebKit/Source/core/html/RadioNodeList.cpp

@@ -93,8 +93,8 @@ bool RadioNodeList::matchesByIdOrName(const Element& testElement) const

bool RadioNodeList::checkElementMatchesRadioNodeListFilter(const Element& testElement) const

{

- ASSERT(!shouldOnlyMatchImgElements());

- ASSERT(isHTMLObjectElement(testElement) || testElement.isFormControlElement());

+ DCHECK(!shouldOnlyMatchImgElements());

+ DCHECK(isHTMLObjectElement(testElement) || testElement.isFormControlElement());

if (isHTMLFormElement(ownerNode())) {

HTMLFormElement* formElement = toHTMLElement(testElement).formOwner();

if (!formElement || formElement != ownerNode())

« no previous file with comments | « third_party/WebKit/Source/core/html/RadioNodeList.h ('k') | third_party/WebKit/Source/core/html/TimeRanges.cpp » ('j') | no next file with comments »