third_party/WebKit/Source/core/html/HTMLViewSourceDocument.cpp - Issue 2258033002: Replace ASSERT()s with DCHECK*() in core/html/*.{cpp,h}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLViewSourceDocument.cpp

Issue 2258033002: Replace ASSERT()s with DCHECK*() in core/html/*.{cpp,h}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Replace ASSERT()s with DCHECK*() in core/html/*.{cpp,h}. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp ('k') | third_party/WebKit/Source/core/html/ImageData.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLViewSourceDocument.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLViewSourceDocument.cpp b/third_party/WebKit/Source/core/html/HTMLViewSourceDocument.cpp

index 184826dc98fd70fc6260a8dd02dd23fad5db03c9..ae67a7feac7f372d44e0821047ce75e5114b23b7 100644

--- a/third_party/WebKit/Source/core/html/HTMLViewSourceDocument.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLViewSourceDocument.cpp

@@ -97,7 +97,7 @@ void HTMLViewSourceDocument::addSource(const String& source, HTMLToken& token, S

switch (token.type()) {

case HTMLToken::Uninitialized:

- ASSERT_NOT_REACHED();

+ NOTREACHED();

break;

case HTMLToken::DOCTYPE:

processDoctypeToken(source, token);

@@ -145,7 +145,7 @@ void HTMLViewSourceDocument::processTagToken(const String& source, HTMLToken& to

if (iter == token.attributes().end()) {

// We want to show the remaining characters in the token.

index = addRange(source, index, source.length(), emptyAtom);

- ASSERT(index == source.length());

+ DCHECK_EQ(index, source.length());

break;

}

@@ -258,7 +258,7 @@ void HTMLViewSourceDocument::addText(const String& text, const AtomicString& cla

int HTMLViewSourceDocument::addRange(const String& source, int start, int end, const AtomicString& className, bool isLink, bool isAnchor, const AtomicString& link)

{

- ASSERT(start <= end);

+ DCHECK_LE(start, end);

if (start == end)

return start;