third_party/WebKit/Source/core/html/HTMLTagCollection.h - Issue 2258033002: Replace ASSERT()s with DCHECK*() in core/html/*.{cpp,h}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLTagCollection.h

Issue 2258033002: Replace ASSERT()s with DCHECK*() in core/html/*.{cpp,h}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Replace ASSERT()s with DCHECK*() in core/html/*.{cpp,h}. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLTableRowsCollection.cpp ('k') | third_party/WebKit/Source/core/html/HTMLTagCollection.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLTagCollection.h

diff --git a/third_party/WebKit/Source/core/html/HTMLTagCollection.h b/third_party/WebKit/Source/core/html/HTMLTagCollection.h

index 9cb86923fa3b96dcfdd249e3e0263be95e05954a..cf714772f4bdb07a7953cdc2fb8e3b32b8ecf230 100644

--- a/third_party/WebKit/Source/core/html/HTMLTagCollection.h

+++ b/third_party/WebKit/Source/core/html/HTMLTagCollection.h

@@ -35,7 +35,7 @@ class HTMLTagCollection final : public TagCollection {

public:

static HTMLTagCollection* create(ContainerNode& rootNode, CollectionType type, const AtomicString& localName)

{

- ASSERT_UNUSED(type, type == HTMLTagCollectionType);

+ DCHECK_EQ(type, HTMLTagCollectionType);

return new HTMLTagCollection(rootNode, localName);

}

@@ -57,7 +57,7 @@ inline bool HTMLTagCollection::elementMatches(const Element& testElement) const

if (localName != testElement.localName())

return false;

}

- ASSERT(m_namespaceURI == starAtom);

+ DCHECK_EQ(m_namespaceURI, starAtom);

return true;

}