third_party/WebKit/Source/core/html/HTMLSelectElementTest.cpp - Issue 2258033002: Replace ASSERT()s with DCHECK*() in core/html/*.{cpp,h}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLSelectElementTest.cpp

Issue 2258033002: Replace ASSERT()s with DCHECK*() in core/html/*.{cpp,h}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Replace ASSERT()s with DCHECK*() in core/html/*.{cpp,h}. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLSelectElement.cpp ('k') | third_party/WebKit/Source/core/html/HTMLShadowElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLSelectElementTest.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLSelectElementTest.cpp b/third_party/WebKit/Source/core/html/HTMLSelectElementTest.cpp

index b14fd976c2e9b8b06b3b67df1b6b67e454ae58fe..467e4f95941214d4487ac4dcddaa5c3ad35b2cdd 100644

--- a/third_party/WebKit/Source/core/html/HTMLSelectElementTest.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLSelectElementTest.cpp

@@ -138,7 +138,7 @@ TEST_F(HTMLSelectElementTest, VisibleBoundsInVisualViewport)

document().documentElement()->setInnerHTML("<select style='position:fixed; top:12.3px; height:24px; -webkit-appearance:none;'><option>o1</select>", ASSERT_NO_EXCEPTION);

document().view()->updateAllLifecyclePhases();

HTMLSelectElement* select = toHTMLSelectElement(document().body()->firstChild());

- ASSERT(select);

+ ASSERT_NE(select, nullptr);

IntRect bounds = select->visibleBoundsInVisualViewport();

EXPECT_EQ(24, bounds.height());

}

@@ -148,7 +148,7 @@ TEST_F(HTMLSelectElementTest, PopupIsVisible)

document().documentElement()->setInnerHTML("<select><option>o1</option></select>", ASSERT_NO_EXCEPTION);

document().view()->updateAllLifecyclePhases();

HTMLSelectElement* select = toHTMLSelectElement(document().body()->firstChild());

- ASSERT(select);

+ ASSERT_NE(select, nullptr);

EXPECT_FALSE(select->popupIsVisible());

select->showPopup();

EXPECT_TRUE(select->popupIsVisible());