third_party/WebKit/Source/core/html/HTMLObjectElement.cpp - Issue 2258033002: Replace ASSERT()s with DCHECK*() in core/html/*.{cpp,h}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLObjectElement.cpp

Issue 2258033002: Replace ASSERT()s with DCHECK*() in core/html/*.{cpp,h}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Replace ASSERT()s with DCHECK*() in core/html/*.{cpp,h}. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLObjectElement.h ('k') | third_party/WebKit/Source/core/html/HTMLOptGroupElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLObjectElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLObjectElement.cpp b/third_party/WebKit/Source/core/html/HTMLObjectElement.cpp

index 7a463b99d75a637741ad9d05e1e5eaa0d92327de..7139c150fb786b0d935a46414a5310370ae6db61 100644

--- a/third_party/WebKit/Source/core/html/HTMLObjectElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLObjectElement.cpp

@@ -244,7 +244,7 @@ void HTMLObjectElement::reloadPluginOnAttributeChange(const QualifiedName& name)

} else if (name == classidAttr) {

needsInvalidation = true;

} else {

- ASSERT_NOT_REACHED();

+ NOTREACHED();

needsInvalidation = false;

}

setNeedsWidgetUpdate(true);

@@ -256,8 +256,8 @@ void HTMLObjectElement::reloadPluginOnAttributeChange(const QualifiedName& name)

// moved down into HTMLPluginElement.cpp

void HTMLObjectElement::updateWidgetInternal()

{

- ASSERT(!layoutEmbeddedItem().showsUnavailablePluginIndicator());

- ASSERT(needsWidgetUpdate());

+ DCHECK(!layoutEmbeddedItem().showsUnavailablePluginIndicator());

+ DCHECK(needsWidgetUpdate());

setNeedsWidgetUpdate(false);

// TODO(schenney): crbug.com/572908 This should ASSERT isFinishedParsingChildren() instead.

if (!isFinishedParsingChildren()) {