Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Unified Diff: third_party/WebKit/Source/core/html/HTMLMetaElement-in.cpp

Issue 2258033002: Replace ASSERT()s with DCHECK*() in core/html/*.{cpp,h}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Replace ASSERT()s with DCHECK*() in core/html/*.{cpp,h}. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLMetaElement-in.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLMetaElement-in.cpp b/third_party/WebKit/Source/core/html/HTMLMetaElement-in.cpp
index 93424e4c4f5e8b37871910ff796540b19f30cdcb..48d2db71ab3327ebce8bfba1c24ee07729153512 100644
--- a/third_party/WebKit/Source/core/html/HTMLMetaElement-in.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLMetaElement-in.cpp
@@ -124,7 +124,7 @@ void HTMLMetaElement::parseContentAttribute(const String& content, void* data, D
}
valueEnd = i;
- ASSERT_WITH_SECURITY_IMPLICATION(i <= length);
+ SECURITY_DCHECK(i <= length);
String keyString = buffer.substring(keyBegin, keyEnd - keyBegin);
String valueString = buffer.substring(valueBegin, valueEnd - valueBegin);
@@ -384,7 +384,7 @@ static MessageLevel viewportErrorMessageLevel(ViewportErrorCode errorCode)
return WarningMessageLevel;
}
- ASSERT_NOT_REACHED();
+ NOTREACHED();
return ErrorMessageLevel;
}
@@ -417,7 +417,7 @@ void HTMLMetaElement::getViewportDescriptionFromContentAttribute(const String& c
}
void HTMLMetaElement::processViewportContentAttribute(const String& content, ViewportDescription::Type origin)
{
- ASSERT(!content.isNull());
+ DCHECK(!content.isNull());
if (!document().shouldOverrideLegacyDescription(origin))
return;
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLMapElement.cpp ('k') | third_party/WebKit/Source/core/html/HTMLMeterElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698