Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1848)

Unified Diff: third_party/WebKit/Source/core/html/HTMLFormControlsCollection.cpp

Issue 2258033002: Replace ASSERT()s with DCHECK*() in core/html/*.{cpp,h}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Replace ASSERT()s with DCHECK*() in core/html/*.{cpp,h}. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLFormControlsCollection.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLFormControlsCollection.cpp b/third_party/WebKit/Source/core/html/HTMLFormControlsCollection.cpp
index 8bf636d8e18a91be6460a2c06e0ead6e33389d12..5bfe326e1417cac7ced2d54b54d12942e6e895b7 100644
--- a/third_party/WebKit/Source/core/html/HTMLFormControlsCollection.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLFormControlsCollection.cpp
@@ -43,12 +43,12 @@ HTMLFormControlsCollection::HTMLFormControlsCollection(ContainerNode& ownerNode)
, m_cachedElement(nullptr)
, m_cachedElementOffsetInArray(0)
{
- ASSERT(isHTMLFormElement(ownerNode) || isHTMLFieldSetElement(ownerNode));
+ DCHECK(isHTMLFormElement(ownerNode) || isHTMLFieldSetElement(ownerNode));
}
HTMLFormControlsCollection* HTMLFormControlsCollection::create(ContainerNode& ownerNode, CollectionType type)
{
- ASSERT_UNUSED(type, type == FormControls);
+ DCHECK_EQ(type, FormControls);
return new HTMLFormControlsCollection(ownerNode);
}
@@ -58,7 +58,7 @@ HTMLFormControlsCollection::~HTMLFormControlsCollection()
const FormAssociatedElement::List& HTMLFormControlsCollection::formControlElements() const
{
- ASSERT(isHTMLFormElement(ownerNode()) || isHTMLFieldSetElement(ownerNode()));
+ DCHECK(isHTMLFormElement(ownerNode()) || isHTMLFieldSetElement(ownerNode()));
if (isHTMLFormElement(ownerNode()))
return toHTMLFormElement(ownerNode()).associatedElements();
return toHTMLFieldSetElement(ownerNode()).associatedElements();
@@ -111,7 +111,7 @@ void HTMLFormControlsCollection::invalidateCache(Document* oldDocument) const
static HTMLElement* firstNamedItem(const FormAssociatedElement::List& elementsArray, const QualifiedName& attrName, const String& name)
{
- ASSERT(attrName == idAttr || attrName == nameAttr);
+ DCHECK(attrName == idAttr || attrName == nameAttr);
for (unsigned i = 0; i < elementsArray.size(); ++i) {
HTMLElement* element = toHTMLElement(elementsArray[i]);
@@ -212,7 +212,7 @@ void HTMLFormControlsCollection::supportedPropertyNames(Vector<String>& names)
unsigned length = this->length();
for (unsigned i = 0; i < length; ++i) {
HTMLElement* element = item(i);
- ASSERT(element);
+ DCHECK(element);
const AtomicString& idAttribute = element->getIdAttribute();
if (!idAttribute.isEmpty()) {
HashSet<AtomicString>::AddResult addResult = existingNames.add(idAttribute);

Powered by Google App Engine
This is Rietveld 408576698