Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Unified Diff: third_party/WebKit/Source/core/html/HTMLEmbedElement.cpp

Issue 2258033002: Replace ASSERT()s with DCHECK*() in core/html/*.{cpp,h}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Replace ASSERT()s with DCHECK*() in core/html/*.{cpp,h}. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLEmbedElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLEmbedElement.cpp b/third_party/WebKit/Source/core/html/HTMLEmbedElement.cpp
index d32ac2788fd4b4ed8a80d47ab16b983bf7a82bad..e5f738a1641a1d969335b39ad813f38fc6f78e5c 100644
--- a/third_party/WebKit/Source/core/html/HTMLEmbedElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLEmbedElement.cpp
@@ -126,8 +126,8 @@ void HTMLEmbedElement::parametersForPlugin(Vector<String>& paramNames, Vector<St
// moved down into HTMLPluginElement.cpp
void HTMLEmbedElement::updateWidgetInternal()
{
- ASSERT(!layoutEmbeddedItem().showsUnavailablePluginIndicator());
- ASSERT(needsWidgetUpdate());
+ DCHECK(!layoutEmbeddedItem().showsUnavailablePluginIndicator());
+ DCHECK(needsWidgetUpdate());
setNeedsWidgetUpdate(false);
if (m_url.isEmpty() && m_serviceType.isEmpty())
@@ -181,9 +181,9 @@ bool HTMLEmbedElement::layoutObjectIsNeeded(const ComputedStyle& style)
// fallback content.
ContainerNode* p = parentNode();
if (isHTMLObjectElement(p)) {
- ASSERT(p->layoutObject());
+ DCHECK(p->layoutObject());
if (!toHTMLObjectElement(p)->useFallbackContent()) {
- ASSERT(!p->layoutObject()->isEmbeddedObject());
+ DCHECK(!p->layoutObject()->isEmbeddedObject());
return false;
}
}
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLElement.cpp ('k') | third_party/WebKit/Source/core/html/HTMLFontElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698