third_party/WebKit/Source/core/html/HTMLDetailsElement.cpp - Issue 2258033002: Replace ASSERT()s with DCHECK*() in core/html/*.{cpp,h}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLDetailsElement.cpp

Issue 2258033002: Replace ASSERT()s with DCHECK*() in core/html/*.{cpp,h}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Replace ASSERT()s with DCHECK*() in core/html/*.{cpp,h}. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLDataListOptionsCollection.h ('k') | third_party/WebKit/Source/core/html/HTMLDialogElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLDetailsElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLDetailsElement.cpp b/third_party/WebKit/Source/core/html/HTMLDetailsElement.cpp

index bc329ff6f68854d3a218511215cc37f15f272061..44b8c76a9d12beb8d324a2b63f5087dd4e2cdf21 100644

--- a/third_party/WebKit/Source/core/html/HTMLDetailsElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLDetailsElement.cpp

@@ -97,7 +97,7 @@ HTMLDetailsElement::~HTMLDetailsElement()

void HTMLDetailsElement::dispatchPendingEvent(DetailsEventSender* eventSender)

{

- ASSERT_UNUSED(eventSender, eventSender == &detailsToggleEventSender());

+ DCHECK_EQ(eventSender, &detailsToggleEventSender());

dispatchEvent(Event::create(EventTypeNames::toggle));

}

@@ -130,7 +130,8 @@ Element* HTMLDetailsElement::findMainSummary() const

return summary;

HTMLContentElement* content = toHTMLContentElement(userAgentShadowRoot()->firstChild());

- ASSERT(content->firstChild() && isHTMLSummaryElement(*content->firstChild()));

+ DCHECK(content->firstChild());

+ DCHECK(isHTMLSummaryElement(*content->firstChild()));

return toElement(content->firstChild());

}

@@ -147,7 +148,7 @@ void HTMLDetailsElement::parseAttribute(const QualifiedName& name, const AtomicS

detailsToggleEventSender().dispatchEventSoon(this);

Element* content = ensureUserAgentShadowRoot().getElementById(ShadowElementNames::detailsContent());

- ASSERT(content);

+ DCHECK(content);

if (m_isOpen)

content->removeInlineStyleProperty(CSSPropertyDisplay);

else

@@ -156,7 +157,7 @@ void HTMLDetailsElement::parseAttribute(const QualifiedName& name, const AtomicS

// Invalidate the LayoutDetailsMarker in order to turn the arrow signifying if the

// details element is open or closed.

Element* summary = findMainSummary();

- ASSERT(summary);

+ DCHECK(summary);

Element* control = toHTMLSummaryElement(summary)->markerControl();

if (control && control->layoutObject())