third_party/WebKit/Source/core/html/HTMLContentElement.cpp - Issue 2258033002: Replace ASSERT()s with DCHECK*() in core/html/*.{cpp,h}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLContentElement.cpp

Issue 2258033002: Replace ASSERT()s with DCHECK*() in core/html/*.{cpp,h}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Replace ASSERT()s with DCHECK*() in core/html/*.{cpp,h}. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLCollection.cpp ('k') | third_party/WebKit/Source/core/html/HTMLDataListOptionsCollection.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLContentElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLContentElement.cpp b/third_party/WebKit/Source/core/html/HTMLContentElement.cpp

index eb7def64d3de0d6af8df805508d552504e22bb2a..8621d34349acf819dabbe5159f4a72ee10343304 100644

--- a/third_party/WebKit/Source/core/html/HTMLContentElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLContentElement.cpp

@@ -63,7 +63,7 @@ DEFINE_TRACE(HTMLContentElement)

void HTMLContentElement::parseSelect()

{

- ASSERT(m_shouldParseSelect);

+ DCHECK(m_shouldParseSelect);

m_selectorList = CSSParser::parseSelector(CSSParserContext(document(), nullptr), nullptr, m_select);

m_shouldParseSelect = false;

@@ -97,7 +97,7 @@ static inline bool includesDisallowedPseudoClass(const CSSSelector& selector)

bool HTMLContentElement::validateSelect() const

{

- ASSERT(!m_shouldParseSelect);

+ DCHECK(!m_shouldParseSelect);

if (m_select.isNull() || m_select.isEmpty())

return true;