third_party/WebKit/Source/core/html/HTMLCollection.h - Issue 2258033002: Replace ASSERT()s with DCHECK*() in core/html/*.{cpp,h}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLCollection.h

Issue 2258033002: Replace ASSERT()s with DCHECK*() in core/html/*.{cpp,h}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Replace ASSERT()s with DCHECK*() in core/html/*.{cpp,h}. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLButtonElement.cpp ('k') | third_party/WebKit/Source/core/html/HTMLCollection.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLCollection.h

diff --git a/third_party/WebKit/Source/core/html/HTMLCollection.h b/third_party/WebKit/Source/core/html/HTMLCollection.h

index b96c8d9867499238bf27cb27f7276f4d7e852198..079e2cca29df6d598985817aa75c08a9f30b34e3 100644

--- a/third_party/WebKit/Source/core/html/HTMLCollection.h

+++ b/third_party/WebKit/Source/core/html/HTMLCollection.h

@@ -114,7 +114,7 @@ protected:

void setNamedItemCache(NamedItemCache* cache) const

{

- ASSERT(!m_namedItemCache);

+ DCHECK(!m_namedItemCache);

// Do not repeat registration for the same invalidation type.

if (invalidationType() != InvalidateOnIdNameAttrChange)

document().registerNodeListWithIdNameCache(this);

@@ -123,7 +123,7 @@ protected:

NamedItemCache& namedItemCache() const

{

- ASSERT(m_namedItemCache);

+ DCHECK(m_namedItemCache);

return *m_namedItemCache;

}

@@ -143,7 +143,7 @@ private:

void unregisterIdNameCacheFromDocument(Document& document) const

{

- ASSERT(hasValidIdNameCache());

+ DCHECK(hasValidIdNameCache());

// Do not repeat unregistration for the same invalidation type.

if (invalidationType() != InvalidateOnIdNameAttrChange)

document.unregisterNodeListWithIdNameCache(this);