third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp - Issue 2258033002: Replace ASSERT()s with DCHECK*() in core/html/*.{cpp,h}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp

Issue 2258033002: Replace ASSERT()s with DCHECK*() in core/html/*.{cpp,h}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Replace ASSERT()s with DCHECK*() in core/html/*.{cpp,h}. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLAllCollection.cpp ('k') | third_party/WebKit/Source/core/html/HTMLAreaElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp b/third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp

index 4e9e4a4d5458aa722f5c8017882623d2d04d84ac..eafc7bd93c69f5eb24eac96b254285d742d39943 100644

--- a/third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp

@@ -177,7 +177,7 @@ bool HTMLAnchorElement::isMouseFocusable() const

bool HTMLAnchorElement::isKeyboardFocusable() const

{

- ASSERT(document().isActive());

+ DCHECK(document().isActive());

if (isFocusable() && Element::supportsFocus())

return HTMLElement::isKeyboardFocusable();

@@ -192,9 +192,9 @@ static void appendServerMapMousePosition(StringBuilder& url, Event* event)

if (!event->isMouseEvent())

return;

- ASSERT(event->target());

+ DCHECK(event->target());

Node* target = event->target()->toNode();

- ASSERT(target);

+ DCHECK(target);

if (!isHTMLImageElement(*target))

return;