Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Unified Diff: third_party/WebKit/Source/core/html/FormData.cpp

Issue 2258033002: Replace ASSERT()s with DCHECK*() in core/html/*.{cpp,h}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Replace ASSERT()s with DCHECK*() in core/html/*.{cpp,h}. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/FormData.cpp
diff --git a/third_party/WebKit/Source/core/html/FormData.cpp b/third_party/WebKit/Source/core/html/FormData.cpp
index 470f40cb4bc69356c711a8c5e18d71381e75bf1c..2e4221fc05b6496ecf6c05d4659c04c77006708c 100644
--- a/third_party/WebKit/Source/core/html/FormData.cpp
+++ b/third_party/WebKit/Source/core/html/FormData.cpp
@@ -56,7 +56,7 @@ public:
if (entry.isString()) {
value.setUSVString(m_formData->decode(entry.value()));
} else {
- ASSERT(entry.isFile());
+ DCHECK(entry.isFile());
value.setFile(entry.file());
}
return true;
@@ -144,7 +144,7 @@ void FormData::get(const String& name, FormDataEntryValue& result)
if (entry->isString()) {
result.setUSVString(decode(entry->value()));
} else {
- ASSERT(entry->isFile());
+ DCHECK(entry->isFile());
result.setFile(entry->file());
}
return;
@@ -164,7 +164,7 @@ HeapVector<FormDataEntryValue> FormData::getAll(const String& name)
if (entry->isString()) {
value.setUSVString(decode(entry->value()));
} else {
- ASSERT(entry->isFile());
+ DCHECK(entry->isFile());
value.setFile(entry->file());
}
results.append(value);
@@ -194,7 +194,7 @@ void FormData::set(const String& name, Blob* blob, const String& filename)
void FormData::setEntry(const Entry* entry)
{
- ASSERT(entry);
+ DCHECK(entry);
const CString encodedName = entry->name();
bool found = false;
size_t i = 0;
@@ -329,7 +329,7 @@ DEFINE_TRACE(FormData::Entry)
File* FormData::Entry::file() const
{
- ASSERT(blob());
+ DCHECK(blob());
// The spec uses the passed filename when inserting entries into the list.
// Here, we apply the filename (if present) as an override when extracting
// entries.

Powered by Google App Engine
This is Rietveld 408576698