third_party/WebKit/Source/core/html/CollectionItemsCache.h - Issue 2258033002: Replace ASSERT()s with DCHECK*() in core/html/*.{cpp,h}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/CollectionItemsCache.h

Issue 2258033002: Replace ASSERT()s with DCHECK*() in core/html/*.{cpp,h}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Replace ASSERT()s with DCHECK*() in core/html/*.{cpp,h}. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/CollectionIndexCache.h ('k') | third_party/WebKit/Source/core/html/DocumentNameCollection.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/CollectionItemsCache.h

diff --git a/third_party/WebKit/Source/core/html/CollectionItemsCache.h b/third_party/WebKit/Source/core/html/CollectionItemsCache.h

index 994ca459c5a04c85708a3ca25c55a0097a574fd0..607a75c536876528b881f40259c5ca07c872787c 100644

--- a/third_party/WebKit/Source/core/html/CollectionItemsCache.h

+++ b/third_party/WebKit/Source/core/html/CollectionItemsCache.h

@@ -105,7 +105,7 @@ template <typename Collection, typename NodeType>

inline NodeType* CollectionItemsCache<Collection, NodeType>::nodeAt(const Collection& collection, unsigned index)

{

if (m_listValid) {

- ASSERT(this->isCachedNodeCountValid());

+ DCHECK(this->isCachedNodeCountValid());

return index < this->cachedNodeCount() ? m_cachedList[index] : nullptr;

}

return Base::nodeAt(collection, index);