[WebSocket] Ignore connection errors in the shutdown sequence

content/renderer/websockethandle_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/websockethandle_impl.h"
 
 #include <stdint.h>
 #include <string.h>
 
 #include <string>
@@ skipping 141 matching lines @@
   if (websocket_)
     websocket_->StartClosingHandshake(kAbnormalShutdownOpCode, std::string());
 }
 
 void WebSocketHandleImpl::Disconnect() {
   websocket_.reset();
   client_ = nullptr;
 }
 
 void WebSocketHandleImpl::OnConnectionError() {
+  if (!blink::Platform::current()) {

[darin (slow to review), 2016/08/19 15:54:16]

This seems like a sensible band-aid.

+    // In the renderrer shutdown sequence, mojo channels are destructed and this
+    // function is called. On the other hand, blink objects became invalid
+    // *silently*, which means we must not touch |*client_| any more.
+    // TODO(yhirano): Remove this code once the shutdown sequence is fixed.
+    Disconnect();
+    return;
+  }
+
   // Our connection to the WebSocket was dropped. This could be due to
   // exceeding the maximum number of concurrent websockets from this process.
 
   // TODO(darin): This error message is overly specific. We don't know for sure
   // that this is the only reason we'd get here. This should be more generic or
   // we should figure out how to make it more specific.
   OnFailChannel("Error in connection establishment: "
                 "net::ERR_INSUFFICIENT_RESOURCES");
 }
 
@@ skipping 118 matching lines @@
   DVLOG(1) << "WebSocketHandleImpl @" << reinterpret_cast<void*>(this)
            << " OnClosingHandshake()";
   if (!client_)
     return;
 
   client_->didStartClosingHandshake(this);
   // |this| can be deleted here.
 }
 
 }  // namespace content