Issue 22580004: add ui for mutli-rebaselining

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22580004: add ui for mutli-rebaselining (Closed)

Created:
7 years, 4 months ago by Zach Reizner

Modified:
7 years, 4 months ago

Reviewers:
epoger, djsollen

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

add ui for mutli-rebaselining R=epoger@google.com Committed: https://code.google.com/p/skia/source/detail?r=10618

Patch Set 2 : better commit rebaselines comment #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+242 lines, -90 lines)			Patch
M	tools/skpdiff/diff_viewer.js	View		3 chunks	+52 lines, -12 lines	0 comments	Download
M	tools/skpdiff/skpdiff_server.py	View	1	10 chunks	+74 lines, -33 lines	0 comments	Download
M	tools/skpdiff/viewer.html	View		1 chunk	+56 lines, -43 lines	0 comments	Download
M	tools/skpdiff/viewer_style.css	View		3 chunks	+60 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

epoger

lgtm https://codereview.chromium.org/22580004/diff/1/tools/skpdiff/skpdiff_server.py File tools/skpdiff/skpdiff_server.py (right): https://codereview.chromium.org/22580004/diff/1/tools/skpdiff/skpdiff_server.py#newcode387 tools/skpdiff/skpdiff_server.py:387: # Reset all expectations to their old hashes ...

7 years, 4 months ago (2013-08-07 16:51:55 UTC) #2

Zach Reizner

7 years, 4 months ago (2013-08-07 18:06:43 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r10618 (presubmit successful).

Expand Messages | Collapse Messages

Issue 22580004: add ui for mutli-rebaselining (Closed)

Description

Patch Set 1 #

Patch Set 2 : better commit rebaselines comment #

Messages