Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issue 22580003: MIPS: First implementation of allocation elimination in Hydrogen. (Closed)

Created:
7 years, 4 months ago by palfia
Modified:
7 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: First implementation of allocation elimination in Hydrogen. Port r16098 (328ff5f7) Original commit message: This change implements a simple data-flow analysis pass over captured objects to the existing escape analysis. It tracks the state of values in the Hydrogen graph through CapturedObject marker instructions that are used to construct an appropriate translation for the deoptimizer to be able to materialize these objects again. This can be considered a combination of scalar replacement of loads and stores on captured objects and sinking of unused allocations. TEST=mjsunit/compiler/escape-analysis BUG= Committed: https://code.google.com/p/v8/source/detail?r=16107

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -42 lines) Patch
M src/mips/lithium-codegen-mips.h View 1 chunk +5 lines, -2 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +41 lines, -21 lines 0 comments Download
M src/mips/lithium-mips.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/mips/lithium-mips.cc View 5 chunks +46 lines, -18 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
palfia
PTAL.
7 years, 4 months ago (2013-08-07 15:39:54 UTC) #1
Michael Starzinger
LGTM.
7 years, 4 months ago (2013-08-07 15:45:22 UTC) #2
palfia
7 years, 4 months ago (2013-08-07 16:34:29 UTC) #3
Message was sent while issue was closed.
Committed manually as r16107 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698