Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 2257993002: Revert of Return color shader instead of 2-color gradient when color count is 1 (Closed)

Created:
4 years, 4 months ago by reed1
Modified:
4 years, 4 months ago
Reviewers:
fmenozzi
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Return color shader instead of 2-color gradient when color count is 1 (patchset #3 id:40001 of https://codereview.chromium.org/2259823005/ ) Reason for revert: breaks 2-pt-conical, which can sometimes not draw anything Original issue's description: > Return color shader instead of 2-color gradient when color count is 1 > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2259823005 > > Committed: https://skia.googlesource.com/skia/+/da082a5767d7edfd3abe74fc683392422565a606 TBR=fmenozzi@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/6b7a6c74dcf84ee00ed5a24d27ed9baca8fce10f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -12 lines) Patch
M src/effects/gradients/SkGradientShader.cpp View 5 chunks +17 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
reed1
Created Revert of Return color shader instead of 2-color gradient when color count is 1
4 years, 4 months ago (2016-08-18 23:13:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2257993002/1
4 years, 4 months ago (2016-08-18 23:13:45 UTC) #3
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 23:13:54 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/6b7a6c74dcf84ee00ed5a24d27ed9baca8fce10f

Powered by Google App Engine
This is Rietveld 408576698