third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp - Issue 2257943002: Remove LinkPreload resource type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp

Issue 2257943002: Remove LinkPreload resource type (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Really fixed test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/fetch/Resource.cpp ('k') | third_party/WebKit/Source/core/html/parser/HTMLPreloadScannerTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp

diff --git a/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp b/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp

index c4ab711b0903d38ea0d8121df4aa7cffac881516..7388bbeb8b3e35e353a474b9c2d625dab477636f 100644

--- a/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp

+++ b/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp

@@ -82,7 +82,6 @@ enum SriResourceIntegrityMismatchEvent {

DEFINE_SINGLE_RESOURCE_HISTOGRAM(prefix, Image) \

DEFINE_SINGLE_RESOURCE_HISTOGRAM(prefix, ImportResource) \

DEFINE_SINGLE_RESOURCE_HISTOGRAM(prefix, LinkPrefetch) \

- DEFINE_SINGLE_RESOURCE_HISTOGRAM(prefix, LinkPreload) \

DEFINE_SINGLE_RESOURCE_HISTOGRAM(prefix, MainResource) \

DEFINE_SINGLE_RESOURCE_HISTOGRAM(prefix, Manifest) \

DEFINE_SINGLE_RESOURCE_HISTOGRAM(prefix, Media) \

@@ -120,7 +119,6 @@ static ResourceLoadPriority typeToPriority(Resource::Type type)

// Also late-body scripts discovered by the preload scanner (set explicitly in loadPriority)

return ResourceLoadPriorityMedium;

case Resource::Image:

- case Resource::LinkPreload:

case Resource::TextTrack:

case Resource::Media:

case Resource::SVGDocument:

@@ -159,8 +157,7 @@ ResourceLoadPriority ResourceFetcher::computeLoadPriority(Resource::Type type, c

else if (request.forPreload() && m_imageFetched)

priority = ResourceLoadPriorityMedium;

} else if (FetchRequest::LazyLoad == request.defer()) {

- // A deferred load of type Raw is a link rel=preload, which should be Low instead of VeryLow.

- priority = type == Resource::Raw ? ResourceLoadPriorityLow : ResourceLoadPriorityVeryLow;

+ priority = ResourceLoadPriorityVeryLow;

}

// A manually set priority acts as a floor. This is used to ensure that synchronous requests

@@ -200,8 +197,6 @@ static WebURLRequest::RequestContext requestContextFromType(bool isMainFrame, Re

return WebURLRequest::RequestContextImport;

case Resource::LinkPrefetch:

return WebURLRequest::RequestContextPrefetch;

- case Resource::LinkPreload:

- return WebURLRequest::RequestContextSubresource;

case Resource::TextTrack:

return WebURLRequest::RequestContextTrack;

case Resource::SVGDocument: