Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2257933004: [Android] Make cpu_features dependent on configurable android_ndk_root (Closed)

Created:
4 years, 4 months ago by Eden Wang
Modified:
4 years, 4 months ago
CC:
chromium-reviews, scottmg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Make cpu_features dependent on configurable android_ndk_root There are compiler errors while building libstandalonelibwebviewchromium only. The pathes for cpu_features are source-tree absolute pathes. BUG=637218 Committed: https://crrev.com/d504ece7d368e6d82ad0467a9b82445c2f1345eb Cr-Commit-Position: refs/heads/master@{#413544}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/secondary/third_party/android_tools/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Eden Wang
Hi scottmg, I have got some compiler errors while building libstandalonelibwebviewchromium only if I put ...
4 years, 4 months ago (2016-08-19 05:52:04 UTC) #3
scottmg
Hi nedenwang, this seems reasonable to me, but I'm not familiar with Android builds, so ...
4 years, 4 months ago (2016-08-19 16:12:18 UTC) #5
agrieve
On 2016/08/19 16:12:18, scottmg wrote: > Hi nedenwang, this seems reasonable to me, but I'm ...
4 years, 4 months ago (2016-08-22 20:10:13 UTC) #6
agrieve
On 2016/08/22 20:10:13, agrieve (OOO until aug 22) wrote: > On 2016/08/19 16:12:18, scottmg wrote: ...
4 years, 4 months ago (2016-08-22 20:30:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2257933004/1
4 years, 4 months ago (2016-08-22 20:32:42 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-22 21:47:41 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 21:51:04 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d504ece7d368e6d82ad0467a9b82445c2f1345eb
Cr-Commit-Position: refs/heads/master@{#413544}

Powered by Google App Engine
This is Rietveld 408576698