Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2257893002: Delete all test isolate file. (Closed)

Created:
4 years, 4 months ago by M-A Ruel
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke, jbudorick
CC:
chromium-reviews, sadrul, oshima+watch_chromium.org, zea+watch_chromium.org, viettrungluu+watch_chromium.org, nektar+watch_chromium.org, johnme+watch_chromium.org, yzshen+watch_chromium.org, sievers+watch_chromium.org, pennymac+watch_chromium.org, dmazzoni+watch_chromium.org, kinuko+watch, ben+mojo_chromium.org, blink-reviews-wtf_chromium.org, miu+watch_chromium.org, extensions-reviews_chromium.org, qsr+mojo_chromium.org, Matt Giuca, toyoshim+midi_chromium.org, aboxhall+watch_chromium.org, grt+watch_chromium.org, chromoting-reviews_chromium.org, jam, abarth-chromium, jbauman+watch_chromium.org, je_julie, darin-cc_chromium.org, huangs+watch_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, xjz+watch_chromium.org, imcheng+watch_chromium.org, Mads Ager (chromium), tdresser+watch_chromium.org, Peter Beverloo, jasonroberts+watch_google.com, mlamouri+watch-notifications_chromium.org, cbentzel+watch_chromium.org, yuzo+watch_chromium.org, rickyz+watch_chromium.org, feature-media-reviews_chromium.org, mcasas+watch+vc_chromium.org, caitkp+watch_chromium.org, haraken, piman+watch_chromium.org, danakj+watch_chromium.org, darin (slow to review), kalyank, media-router+watch_chromium.org, Ian Vollick, wfh+watch_chromium.org, avayvod+watch_chromium.org, Aaron Boodman, telemetry-reviews_chromium.org, dtseng+watch_chromium.org, tfarina, oilpan-reviews, cc-bugs_chromium.org, kouhei+heap_chromium.org, isheriff+watch_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete all test isolate file now that M54 was branched. The runtime dependencies data was successfully transitioned to GN. Keep non-testing isolate as some projects (v8, webrtc) still need some. They will be curated incrementally. Ran: $ git rm $(git ls-files -- "*.isolate" | grep -i test | grep -v testserver) $ git ls-files -- "*.isolate" | wc -l 14 TBR=dpranke@chromium.org BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/95b6282dd54e942098f39c3e6e2a8553c8b759bd Cr-Commit-Position: refs/heads/master@{#415954}

Patch Set 1 #

Patch Set 2 : Removed grep -v _apk #

Patch Set 3 : Rebasing against ToT just in case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5798 lines) Patch
D android_webview/android_webview_unittests_apk.isolate View 1 1 chunk +0 lines, -18 lines 0 comments Download
D ash/ash_unittests.isolate View 1 chunk +0 lines, -64 lines 0 comments Download
D base/base_unittests.isolate View 1 chunk +0 lines, -56 lines 0 comments Download
D base/base_unittests_apk.isolate View 1 1 chunk +0 lines, -25 lines 0 comments Download
D breakpad/breakpad_unittests_apk.isolate View 1 1 chunk +0 lines, -18 lines 0 comments Download
D cc/cc_perftests.isolate View 1 chunk +0 lines, -14 lines 0 comments Download
D cc/cc_unittests.isolate View 1 chunk +0 lines, -85 lines 0 comments Download
D cc/cc_unittests_apk.isolate View 1 1 chunk +0 lines, -18 lines 0 comments Download
D chrome/angle_deqp_egl_tests.isolate View 1 chunk +0 lines, -39 lines 0 comments Download
D chrome/angle_deqp_gles2_tests.isolate View 1 chunk +0 lines, -39 lines 0 comments Download
D chrome/angle_deqp_gles3_tests.isolate View 1 chunk +0 lines, -39 lines 0 comments Download
D chrome/angle_end2end_tests.isolate View 1 chunk +0 lines, -18 lines 0 comments Download
D chrome/angle_unittests.isolate View 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/browser_tests.isolate View 1 chunk +0 lines, -304 lines 0 comments Download
D chrome/chrome_app_unittests.isolate View 1 chunk +0 lines, -40 lines 0 comments Download
D chrome/chromedriver_unittests.isolate View 1 chunk +0 lines, -47 lines 0 comments Download
D chrome/gl_tests.isolate View 1 chunk +0 lines, -18 lines 0 comments Download
D chrome/gles2_conform_test.isolate View 1 chunk +0 lines, -33 lines 0 comments Download
D chrome/install_static_unittests.isolate View 1 chunk +0 lines, -17 lines 0 comments Download
D chrome/installer/mini_installer_tests.isolate View 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/installer_util_unittests.isolate View 1 chunk +0 lines, -21 lines 0 comments Download
D chrome/interactive_ui_tests.isolate View 1 chunk +0 lines, -150 lines 0 comments Download
D chrome/setup_unittests.isolate View 1 chunk +0 lines, -21 lines 0 comments Download
D chrome/sync_integration_tests.isolate View 1 chunk +0 lines, -110 lines 0 comments Download
D chrome/tab_capture_end2end_tests.isolate View 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/telemetry_gpu_integration_test.isolate View 1 chunk +0 lines, -34 lines 0 comments Download
D chrome/telemetry_gpu_test.isolate View 1 chunk +0 lines, -34 lines 0 comments Download
D chrome/telemetry_gpu_unittests.isolate View 1 chunk +0 lines, -33 lines 0 comments Download
D chrome/telemetry_perf_unittests.isolate View 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/telemetry_perf_unittests_android.isolate View 1 chunk +0 lines, -29 lines 0 comments Download
D chrome/telemetry_unittests.isolate View 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/test/media_router/media_router_perf_tests.isolate View 1 chunk +0 lines, -32 lines 0 comments Download
D chrome/test/media_router/media_router_tests.isolate View 1 chunk +0 lines, -28 lines 0 comments Download
D chrome/unit_tests.isolate View 1 chunk +0 lines, -166 lines 0 comments Download
D chrome/unit_tests_apk.isolate View 1 1 chunk +0 lines, -28 lines 0 comments Download
D chrome_elf/chrome_elf_unittests.isolate View 1 chunk +0 lines, -22 lines 0 comments Download
D chromeos/chromeos_unittests.isolate View 1 chunk +0 lines, -24 lines 0 comments Download
D components/components_browsertests.isolate View 1 chunk +0 lines, -85 lines 0 comments Download
D components/components_browsertests_apk.isolate View 1 1 chunk +0 lines, -28 lines 0 comments Download
D components/components_unittests.isolate View 1 chunk +0 lines, -96 lines 0 comments Download
D components/components_unittests_apk.isolate View 1 1 chunk +0 lines, -26 lines 0 comments Download
D components/nacl_helper_nonsfi_unittests.isolate View 1 chunk +0 lines, -18 lines 0 comments Download
D components/nacl_loader_unittests.isolate View 1 chunk +0 lines, -18 lines 0 comments Download
D content/content_browsertests.isolate View 1 chunk +0 lines, -138 lines 0 comments Download
D content/content_browsertests_apk.isolate View 1 1 chunk +0 lines, -29 lines 0 comments Download
D content/content_site_isolation_browsertests.isolate View 1 chunk +0 lines, -21 lines 0 comments Download
D content/content_unittests.isolate View 1 chunk +0 lines, -102 lines 0 comments Download
D content/content_unittests_apk.isolate View 1 1 chunk +0 lines, -28 lines 0 comments Download
D courgette/courgette_unittests.isolate View 1 chunk +0 lines, -17 lines 0 comments Download
D crypto/crypto_unittests.isolate View 1 chunk +0 lines, -42 lines 0 comments Download
D device/device_unittests.isolate View 1 chunk +0 lines, -30 lines 0 comments Download
D device/device_unittests_apk.isolate View 1 1 chunk +0 lines, -18 lines 0 comments Download
D extensions/extensions_browsertests.isolate View 1 chunk +0 lines, -84 lines 0 comments Download
D extensions/extensions_unittests.isolate View 1 chunk +0 lines, -75 lines 0 comments Download
D extensions/shell/app_shell_unittests.isolate View 1 chunk +0 lines, -72 lines 0 comments Download
D gin/gin_unittests.isolate View 1 chunk +0 lines, -56 lines 0 comments Download
D google_apis/gcm/gcm_unit_tests.isolate View 1 chunk +0 lines, -26 lines 0 comments Download
D google_apis/google_apis_unittests.isolate View 1 chunk +0 lines, -24 lines 0 comments Download
D gpu/command_buffer_gles2_tests_apk.isolate View 1 1 chunk +0 lines, -18 lines 0 comments Download
D gpu/gl_tests_apk.isolate View 1 1 chunk +0 lines, -18 lines 0 comments Download
D gpu/gpu_ipc_service_unittests.isolate View 1 chunk +0 lines, -63 lines 0 comments Download
D gpu/gpu_ipc_service_unittests_apk.isolate View 1 1 chunk +0 lines, -18 lines 0 comments Download
D gpu/gpu_unittests.isolate View 1 chunk +0 lines, -63 lines 0 comments Download
D gpu/gpu_unittests_apk.isolate View 1 1 chunk +0 lines, -18 lines 0 comments Download
D ipc/ipc_tests.isolate View 1 chunk +0 lines, -26 lines 0 comments Download
D ipc/ipc_tests_apk.isolate View 1 1 chunk +0 lines, -18 lines 0 comments Download
D jingle/jingle_unittests.isolate View 1 chunk +0 lines, -26 lines 0 comments Download
D media/audio_unittests.isolate View 1 chunk +0 lines, -69 lines 0 comments Download
D media/blink/media_blink_unittests.isolate View 1 chunk +0 lines, -63 lines 0 comments Download
D media/capture/capture_unittests.isolate View 1 chunk +0 lines, -62 lines 0 comments Download
D media/capture/capture_unittests_apk.isolate View 1 1 chunk +0 lines, -18 lines 0 comments Download
D media/cast/cast_unittests.isolate View 1 chunk +0 lines, -62 lines 0 comments Download
D media/media_perftests.isolate View 1 chunk +0 lines, -14 lines 0 comments Download
D media/media_unittests.isolate View 1 chunk +0 lines, -69 lines 0 comments Download
D media/media_unittests_apk.isolate View 1 1 chunk +0 lines, -24 lines 0 comments Download
D media/midi/midi_unittests.isolate View 1 chunk +0 lines, -62 lines 0 comments Download
D mojo/mojo_common_unittests.isolate View 1 chunk +0 lines, -23 lines 0 comments Download
D mojo/mojo_js_integration_tests.isolate View 1 chunk +0 lines, -49 lines 0 comments Download
D mojo/mojo_js_unittests.isolate View 1 chunk +0 lines, -46 lines 0 comments Download
D mojo/mojo_public_bindings_unittests.isolate View 1 chunk +0 lines, -24 lines 0 comments Download
D mojo/mojo_public_system_unittests.isolate View 1 chunk +0 lines, -23 lines 0 comments Download
D mojo/mojo_system_unittests.isolate View 1 chunk +0 lines, -23 lines 0 comments Download
D net/net_unittests.isolate View 1 chunk +0 lines, -55 lines 0 comments Download
D net/net_unittests_apk.isolate View 1 1 chunk +0 lines, -26 lines 0 comments Download
D ppapi/ppapi_unittests.isolate View 1 chunk +0 lines, -17 lines 0 comments Download
D printing/printing_unittests.isolate View 1 chunk +0 lines, -26 lines 0 comments Download
D remoting/remoting_unittests.isolate View 1 chunk +0 lines, -29 lines 0 comments Download
D remoting/tools/remote_test_helper/remote_test_helper.isolate View 1 chunk +0 lines, -18 lines 0 comments Download
D sandbox/sandbox_linux_unittests.isolate View 1 chunk +0 lines, -23 lines 0 comments Download
D sandbox/sandbox_linux_unittests_apk.isolate View 1 1 chunk +0 lines, -19 lines 0 comments Download
D sandbox/sandbox_mac_unittests.isolate View 1 chunk +0 lines, -9 lines 0 comments Download
D sandbox/sbox_integration_tests.isolate View 1 chunk +0 lines, -37 lines 0 comments Download
D sandbox/sbox_unittests.isolate View 1 chunk +0 lines, -28 lines 0 comments Download
D sandbox/sbox_validation_tests.isolate View 1 chunk +0 lines, -28 lines 0 comments Download
D services/shell/mojo_shell_unittests.isolate View 1 chunk +0 lines, -23 lines 0 comments Download
D skia/skia_unittests.isolate View 1 chunk +0 lines, -42 lines 0 comments Download
D sql/sql_unittests.isolate View 1 chunk +0 lines, -33 lines 0 comments Download
D sql/sql_unittests_apk.isolate View 1 1 chunk +0 lines, -24 lines 0 comments Download
D testing/chromoting/chromoting_browser_tests.isolate View 1 chunk +0 lines, -129 lines 0 comments Download
D testing/chromoting/chromoting_integration_tests.isolate View 1 chunk +0 lines, -56 lines 0 comments Download
D testing/chromoting/multi_machine_example/example_task.isolate View 1 chunk +0 lines, -18 lines 0 comments Download
D testing/chromoting/multi_machine_example/example_test_controller.isolate View 1 chunk +0 lines, -31 lines 0 comments Download
D testing/legion/examples/comm_server/controller.isolate View 1 chunk +0 lines, -18 lines 0 comments Download
D testing/legion/examples/comm_server/task.isolate View 1 chunk +0 lines, -18 lines 0 comments Download
D testing/legion/examples/hello_world/controller_test.isolate View 1 chunk +0 lines, -21 lines 0 comments Download
D testing/legion/examples/hello_world/task_test.isolate View 1 chunk +0 lines, -23 lines 0 comments Download
D testing/legion/examples/http_example/http_client.isolate View 1 chunk +0 lines, -18 lines 0 comments Download
D testing/legion/examples/http_example/http_server.isolate View 1 chunk +0 lines, -18 lines 0 comments Download
D testing/legion/examples/http_example/http_test.isolate View 1 chunk +0 lines, -18 lines 0 comments Download
D testing/legion/examples/subprocess/subprocess_test.isolate View 1 chunk +0 lines, -21 lines 0 comments Download
D testing/legion/examples/subprocess/task.isolate View 1 chunk +0 lines, -22 lines 0 comments Download
D testing/legion/legion.isolate View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/Source/platform/blink_heap_unittests.isolate View 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/WebKit/Source/platform/blink_platform_unittests.isolate View 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/WebKit/Source/platform/heap/BlinkHeapUnitTests.isolate View 1 chunk +0 lines, -40 lines 0 comments Download
D third_party/WebKit/Source/web/WebKitUnitTests.isolate View 1 chunk +0 lines, -47 lines 0 comments Download
D third_party/WebKit/Source/web/webkit_unit_tests.isolate View 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/WebKit/Source/wtf/wtf_unittests.isolate View 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/cacheinvalidation/cacheinvalidation_unittests.isolate View 1 chunk +0 lines, -18 lines 0 comments Download
D tools/battor_agent/battor_agent_unittests.isolate View 1 chunk +0 lines, -27 lines 0 comments Download
D tools/gn/gn_unittests.isolate View 1 chunk +0 lines, -20 lines 0 comments Download
D tools/perf/chrome_telemetry_build/telemetry_chrome_test.isolate View 1 chunk +0 lines, -23 lines 0 comments Download
D ui/accessibility/accessibility_unittests.isolate View 1 chunk +0 lines, -17 lines 0 comments Download
D ui/android/ui_android_unittests_apk.isolate View 1 1 chunk +0 lines, -18 lines 0 comments Download
D ui/app_list/app_list_unittests.isolate View 1 chunk +0 lines, -78 lines 0 comments Download
D ui/app_list/presenter/app_list_presenter_unittests.isolate View 1 chunk +0 lines, -78 lines 0 comments Download
D ui/aura/aura_unittests.isolate View 1 chunk +0 lines, -69 lines 0 comments Download
D ui/base/ui_base_tests.isolate View 1 chunk +0 lines, -18 lines 0 comments Download
D ui/base/ui_base_unittests.isolate View 1 chunk +0 lines, -88 lines 0 comments Download
D ui/base/ui_base_unittests_apk.isolate View 1 1 chunk +0 lines, -21 lines 0 comments Download
D ui/compositor/compositor_unittests.isolate View 1 chunk +0 lines, -58 lines 0 comments Download
D ui/display/display_unittests.isolate View 1 chunk +0 lines, -26 lines 0 comments Download
D ui/events/events_unittests.isolate View 1 chunk +0 lines, -77 lines 0 comments Download
D ui/events/events_unittests_apk.isolate View 1 1 chunk +0 lines, -18 lines 0 comments Download
D ui/gfx/gfx_unittests.isolate View 1 chunk +0 lines, -21 lines 0 comments Download
D ui/gl/gl_unittests.isolate View 1 chunk +0 lines, -17 lines 0 comments Download
D ui/gl/gl_unittests_apk.isolate View 1 1 chunk +0 lines, -18 lines 0 comments Download
D ui/message_center/message_center_unittests.isolate View 1 chunk +0 lines, -78 lines 0 comments Download
D ui/touch_selection/ui_touch_selection_unittests.isolate View 1 chunk +0 lines, -62 lines 0 comments Download
D ui/touch_selection/ui_touch_selection_unittests_apk.isolate View 1 1 chunk +0 lines, -18 lines 0 comments Download
D ui/views/views_unittests.isolate View 1 chunk +0 lines, -70 lines 0 comments Download
D ui/wm/wm_unittests.isolate View 1 chunk +0 lines, -70 lines 0 comments Download
D url/url_unittests.isolate View 1 chunk +0 lines, -26 lines 0 comments Download

Messages

Total messages: 34 (17 generated)
M-A Ruel
4 years, 4 months ago (2016-08-19 14:13:43 UTC) #10
Dirk Pranke
+jbudorick. Basically this is fine but you need to wait until crbug.com/633333 is fixed as ...
4 years, 4 months ago (2016-08-19 20:43:31 UTC) #12
M-A Ruel
On 2016/08/19 20:43:31, Dirk Pranke wrote: > +jbudorick. > > Basically this is fine but ...
4 years, 4 months ago (2016-08-19 20:53:26 UTC) #13
jbudorick
On 2016/08/19 20:53:26, M-A Ruel wrote: > On 2016/08/19 20:43:31, Dirk Pranke wrote: > > ...
4 years, 4 months ago (2016-08-19 21:18:09 UTC) #14
Dirk Pranke
I think this is safe to land now.
4 years, 3 months ago (2016-08-31 18:43:17 UTC) #15
grt (UTC plus 2)
On 2016/08/31 18:43:17, Dirk Pranke wrote: > I think this is safe to land now. ...
4 years, 3 months ago (2016-08-31 18:58:40 UTC) #16
M-A Ruel
On 2016/08/31 18:58:40, grt (UTC plus 2) wrote: > On 2016/08/31 18:43:17, Dirk Pranke wrote: ...
4 years, 3 months ago (2016-08-31 19:17:09 UTC) #18
Will Harris
can you update the docs on generating (and remap-ing) an isolated test before landing this? ...
4 years, 3 months ago (2016-08-31 19:23:37 UTC) #19
Dirk Pranke
On 2016/08/31 19:23:37, Will Harris wrote: > can you update the docs on generating (and ...
4 years, 3 months ago (2016-08-31 19:29:34 UTC) #20
Will Harris
On 2016/08/31 19:29:34, Dirk Pranke wrote: > I have a bug open to update the ...
4 years, 3 months ago (2016-08-31 19:36:07 UTC) #21
M-A Ruel
On 2016/08/31 19:36:07, Will Harris wrote: > On 2016/08/31 19:29:34, Dirk Pranke wrote: > > ...
4 years, 3 months ago (2016-08-31 19:40:32 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2257893002/40001
4 years, 3 months ago (2016-08-31 19:41:11 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/249361)
4 years, 3 months ago (2016-08-31 19:49:44 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2257893002/40001
4 years, 3 months ago (2016-09-01 13:08:51 UTC) #29
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-01 15:13:50 UTC) #31
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/95b6282dd54e942098f39c3e6e2a8553c8b759bd Cr-Commit-Position: refs/heads/master@{#415954}
4 years, 3 months ago (2016-09-01 15:18:01 UTC) #33
Dirk Pranke
4 years, 3 months ago (2016-09-01 18:03:38 UTC) #34
Message was sent while issue was closed.
Woo!

Powered by Google App Engine
This is Rietveld 408576698