Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 2257853003: Remove unused PDFEngine ScrollPosition getter/setter. (Closed)

Created:
4 years, 4 months ago by Lei Zhang
Modified:
4 years, 4 months ago
Reviewers:
tommycli
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused PDFEngine ScrollPosition getter/setter. Committed: https://crrev.com/8201772eae3112220883f4c9685b2a3663dde8ac Cr-Commit-Position: refs/heads/master@{#412972}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -16 lines) Patch
M pdf/pdf_engine.h View 1 chunk +0 lines, -6 lines 0 comments Download
M pdf/pdfium/pdfium_engine.h View 1 chunk +0 lines, -2 lines 0 comments Download
M pdf/pdfium/pdfium_engine.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
Lei Zhang
moar
4 years, 4 months ago (2016-08-18 20:49:18 UTC) #4
tommycli
lgtm
4 years, 4 months ago (2016-08-18 20:51:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2257853003/1
4 years, 4 months ago (2016-08-18 22:02:21 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/264374)
4 years, 4 months ago (2016-08-18 22:50:36 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2257853003/1
4 years, 4 months ago (2016-08-18 22:57:06 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-18 23:48:29 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 23:50:41 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8201772eae3112220883f4c9685b2a3663dde8ac
Cr-Commit-Position: refs/heads/master@{#412972}

Powered by Google App Engine
This is Rietveld 408576698