Add test case for type with partial parameterization by method type parameter

Add test case for type with partial parameterization by method type parameter

BUG=
R=eernst@google.com

Committed: https://github.com/dart-lang/sdk/commit/3cec399d2cf23769c3518aab3e41e06fef6ae4b2

[sra1, 2016-08-19 03:15:56]

sra@google.com changed reviewers:
+ eernst@google.com

[sra1, 2016-08-19 03:15:57]

Without the fix this test crashes dart2js

[eernst, 2016-08-22 14:58:50]

I added a longish comment as I clarified the situation in builder.dart, but
that's just FYI: the conclusion is still LGTM.

https://codereview.chromium.org/2257813003/diff/1/pkg/compiler/lib/src/ssa/bu...
File pkg/compiler/lib/src/ssa/builder.dart (right):

https://codereview.chromium.org/2257813003/diff/1/pkg/compiler/lib/src/ssa/bu...
pkg/compiler/lib/src/ssa/builder.dart:4758: }
This looked a bit surprising at first, but it ended up being resolved as
follows:

I actually had the following in this method for a similar purpose, inserted at
line 4804:

   } else if (type is MethodTypeVariableType) {
     // TODO(eernst): The enclosing `else if` was added to provide minimal
     // support for generic methods: The method type arguments are always
     // pretending to have the value `dynamic`. Revise for full support.
     DynamicType type = const DynamicType();
     JavaScriptBackend backend = compiler.backend;
     ClassElement cls = backend.helpers.DynamicRuntimeType;
     HInstruction instruction =
         new HDynamicType(type, new TypeMask.exact(cls, compiler.world));
     add(instruction);
     return instruction;

This was reviewed by Johnni Winther and it worked for a while. It was removed
again because it wasn't executed by any test case after other changes had been
made. But I believe that you have just fixed this by adding a suitable test (so
it wasn't impossible to reach it after all).

The remaining issue is that I generated code to return an `HDynamicType` whereas
this CL generates code to yield null.

Looking at `analyzeTypeArgument`, `inlineSuperOrRedirect`, and other locations,
I've confirmed that the above approach is used to provide a runtime value for
`dynamic`.

In the end, I have no worries about this!

[sra1, 2016-08-23 17:45:33]

Description was changed from

==========
Add test case for type with partial parameterization by method type parameter

BUG=
==========

to

==========
Add test case for type with partial parameterization by method type parameter

BUG=
R=eernst@google.com

Committed:
https://github.com/dart-lang/sdk/commit/3cec399d2cf23769c3518aab3e41e06fef6ae4b2
==========

[sra1, 2016-08-23 17:45:34]

Committed patchset #1 (id:1) manually as
3cec399d2cf23769c3518aab3e41e06fef6ae4b2 (presubmit successful).