Issue 2257803003: VM: Better code for is-checks and checked mode checks with simple types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2257803003: VM: Better code for is-checks and checked mode checks with simple types (Closed)

Created:
4 years, 4 months ago by Florian Schneider

Modified:
4 years, 4 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

VM: Better code for is-checks and checked mode checks with simple types 1. Avoid a redundant comparison when we test against known cids. 2. Avoid testing against the cid of an abstract class. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/0cb6bdce30f5ea9a894791e6d08c726171005412

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+53 lines, -39 lines)			Patch
M	runtime/vm/flow_graph_compiler_arm.cc	View	3 chunks	+11 lines, -8 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_arm64.cc	View	3 chunks	+11 lines, -8 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View	3 chunks	+11 lines, -8 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_mips.cc	View	3 chunks	+9 lines, -7 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	3 chunks	+11 lines, -8 lines	0 comments	Download

Total messages: 5 (2 generated)

Florian Schneider

4 years, 4 months ago (2016-08-18 21:46:27 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
0cb6bdce30f5ea9a894791e6d08c726171005412 (presubmit successful).