Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: chrome/browser/themes/theme_service.h

Issue 22578004: Check if theme is ready. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address review comments. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/themes/theme_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/themes/theme_service.h
diff --git a/chrome/browser/themes/theme_service.h b/chrome/browser/themes/theme_service.h
index 1452a9a8e0ba7dcdf216ef9cf9a911967f42c50f..2b3c76a9a5065d7e2816aab153d68a7c4db699ac 100644
--- a/chrome/browser/themes/theme_service.h
+++ b/chrome/browser/themes/theme_service.h
@@ -171,7 +171,7 @@ class ThemeService : public base::NonThreadSafe,
#endif // OS_MACOSX
// Clears the platform-specific caches. Do not call directly; it's called
- // from ClearCaches().
+ // from ClearAllThemeData().
virtual void FreePlatformCaches();
Profile* profile() const { return profile_; }
@@ -182,6 +182,11 @@ class ThemeService : public base::NonThreadSafe,
return theme_supplier_.get();
}
+ // True if the theme service is ready to be used.
+ // TODO(pkotwicz): Add DCHECKS to the theme service's getters once
+ // ThemeSource no longer uses the ThemeService when it is not ready.
+ bool ready_;
+
private:
friend class theme_service_internal::ThemeServiceTest;
@@ -233,11 +238,6 @@ class ThemeService : public base::NonThreadSafe,
ui::ResourceBundle& rb_;
Profile* profile_;
- // True if the theme service is ready to be used.
- // TODO(pkotwicz): Add DCHECKS to the theme service's getters once
- // ThemeSource no longer uses the ThemeService when it is not ready.
- bool ready_;
-
scoped_refptr<CustomThemeSupplier> theme_supplier_;
// The number of infobars currently displayed.
« no previous file with comments | « no previous file | chrome/browser/themes/theme_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698