Issue 22578004: Check if theme is ready.

Issue 22578004: Check if theme is ready. (Closed)

Created:
7 years, 4 months ago by Adrian Kuegel

Modified:
7 years, 4 months ago

Reviewers:
pkotwicz, Elliot Glaysher

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Check if theme is ready. When calling NotifyThemeChanged and ClearAllThemeData make sure that the theme is ready. BUG=266982 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216279

Patch Set 2 : Address review comments. #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -22 lines)			Patch
M	chrome/browser/themes/theme_service.h	View	1	3 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/themes/theme_service.cc	View	1	3 chunks	+7 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/gtk/gtk_theme_service.h	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/gtk/gtk_theme_service.cc	View	1	3 chunks	+5 lines, -7 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

pkotwicz

LGTM with requested change. Thanks for fixing this! https://codereview.chromium.org/22578004/diff/1/chrome/browser/ui/gtk/gtk_theme_service.cc File chrome/browser/ui/gtk/gtk_theme_service.cc (right): https://codereview.chromium.org/22578004/diff/1/chrome/browser/ui/gtk/gtk_theme_service.cc#newcode634 chrome/browser/ui/gtk/gtk_theme_service.cc:634: colors_.clear(); ...

7 years, 4 months ago (2013-08-07 16:46:10 UTC) #3

Elliot Glaysher

lgtm (I'll defer to pkotwicz because I don't actually know why that |ready_| variable is ...

7 years, 4 months ago (2013-08-07 17:37:05 UTC) #4

Adrian Kuegel

https://codereview.chromium.org/22578004/diff/1/chrome/browser/ui/gtk/gtk_theme_service.cc File chrome/browser/ui/gtk/gtk_theme_service.cc (right): https://codereview.chromium.org/22578004/diff/1/chrome/browser/ui/gtk/gtk_theme_service.cc#newcode634 chrome/browser/ui/gtk/gtk_theme_service.cc:634: colors_.clear(); On 2013/08/07 16:46:10, pkotwicz wrote: > Can we ...

7 years, 4 months ago (2013-08-07 18:25:33 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akuegel@chromium.org/22578004/9001

7 years, 4 months ago (2013-08-07 18:26:04 UTC) #6

Message was sent while issue was closed.

Change committed as 216279

Expand Messages | Collapse Messages