components/wifi_sync/wifi_credential.cc - Issue 2257793002: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/wifi_sync/wifi_credential.cc

Issue 2257793002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/wifi_sync/wifi_config_delegate_chromeos_unittest.cc ('k') | components/wifi_sync/wifi_credential_syncable_service_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/wifi_sync/wifi_credential.cc

diff --git a/components/wifi_sync/wifi_credential.cc b/components/wifi_sync/wifi_credential.cc

index e4e9544cb9217a06d5cd35d9212e676f60e82d63..bbbb492f260e30f982bffd7fe86ad97702fc1bf2 100644

--- a/components/wifi_sync/wifi_credential.cc

+++ b/components/wifi_sync/wifi_credential.cc

@@ -50,7 +50,7 @@ std::unique_ptr<base::DictionaryValue> WifiCredential::ToOncProperties() const {

if (!WifiSecurityClassToOncSecurityString(security_class(), &onc_security)) {

NOTREACHED() << "Failed to convert SecurityClass with value "

<< security_class();

- return base::WrapUnique(new base::DictionaryValue());

+ return base::MakeUnique<base::DictionaryValue>();

}

std::unique_ptr<base::DictionaryValue> onc_properties(