components/drive/chromeos/file_system/download_operation.cc - Issue 2257793002: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/drive/chromeos/file_system/download_operation.cc

Issue 2257793002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/drive/chromeos/file_system/download_operation.cc

diff --git a/components/drive/chromeos/file_system/download_operation.cc b/components/drive/chromeos/file_system/download_operation.cc

index ba8e57c6d77b61b29685d2725e4843608e06c503..4e8d01d62944220aa3ff0298acdd851b4c398e36 100644

--- a/components/drive/chromeos/file_system/download_operation.cc

+++ b/components/drive/chromeos/file_system/download_operation.cc

@@ -284,7 +284,7 @@ class DownloadOperation::DownloadParams {

void OnCacheFileFound(const base::FilePath& cache_file_path) {

if (!initialized_callback_.is_null()) {

initialized_callback_.Run(FILE_ERROR_OK, cache_file_path,

- base::WrapUnique(new ResourceEntry(*entry_)));

+ base::MakeUnique<ResourceEntry>(*entry_));

}

completion_callback_.Run(FILE_ERROR_OK, cache_file_path, std::move(entry_));

}

@@ -297,7 +297,7 @@ class DownloadOperation::DownloadParams {

DCHECK(entry_);

initialized_callback_.Run(FILE_ERROR_OK, base::FilePath(),

- base::WrapUnique(new ResourceEntry(*entry_)));

+ base::MakeUnique<ResourceEntry>(*entry_));

}

void OnError(FileError error) const {

« no previous file with comments | « components/drive/chromeos/change_list_loader.cc ('k') | components/drive/chromeos/search_metadata.cc » ('j') | no next file with comments »