Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: components/cronet/url_request_context_config_unittest.cc

Issue 2257793002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/url_request_context_config_unittest.cc
diff --git a/components/cronet/url_request_context_config_unittest.cc b/components/cronet/url_request_context_config_unittest.cc
index 2c9508a116a25a3c435a4c6b79a57f551b700366..0c82e96b21a97ec3e57cf47ba7dbe5b956196a06 100644
--- a/components/cronet/url_request_context_config_unittest.cc
+++ b/components/cronet/url_request_context_config_unittest.cc
@@ -72,8 +72,9 @@ TEST(URLRequestContextConfigTest, TestExperimentalOptionPassing) {
net::NetLog net_log;
config.ConfigureURLRequestContextBuilder(&builder, &net_log, nullptr);
// Set a ProxyConfigService to avoid DCHECK failure when building.
- builder.set_proxy_config_service(base::WrapUnique(
- new net::ProxyConfigServiceFixed(net::ProxyConfig::CreateDirect())));
+ builder.set_proxy_config_service(
+ base::MakeUnique<net::ProxyConfigServiceFixed>(
+ net::ProxyConfig::CreateDirect()));
std::unique_ptr<net::URLRequestContext> context(builder.Build());
const net::HttpNetworkSession::Params* params =
context->GetNetworkSessionParams();
@@ -163,8 +164,9 @@ TEST(URLRequestContextConfigTest, SetQuicConnectionMigrationOptions) {
net::NetLog net_log;
config.ConfigureURLRequestContextBuilder(&builder, &net_log, nullptr);
// Set a ProxyConfigService to avoid DCHECK failure when building.
- builder.set_proxy_config_service(base::WrapUnique(
- new net::ProxyConfigServiceFixed(net::ProxyConfig::CreateDirect())));
+ builder.set_proxy_config_service(
+ base::MakeUnique<net::ProxyConfigServiceFixed>(
+ net::ProxyConfig::CreateDirect()));
std::unique_ptr<net::URLRequestContext> context(builder.Build());
const net::HttpNetworkSession::Params* params =
context->GetNetworkSessionParams();

Powered by Google App Engine
This is Rietveld 408576698