components/cronet/android/cronet_url_request_context_adapter.cc - Issue 2257793002: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/cronet_url_request_context_adapter.cc

Issue 2257793002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/cronet_data_reduction_proxy.cc ('k') | components/cronet/android/url_request_context_adapter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/cronet_url_request_context_adapter.cc

diff --git a/components/cronet/android/cronet_url_request_context_adapter.cc b/components/cronet/android/cronet_url_request_context_adapter.cc

index 12de78c57ea7814ae399be0e56a003d0a87f07b7..f805328ad325be5d7193e43434082455a180aef1 100644

--- a/components/cronet/android/cronet_url_request_context_adapter.cc

+++ b/components/cronet/android/cronet_url_request_context_adapter.cc

@@ -639,7 +639,7 @@ void CronetURLRequestContextAdapter::InitializeOnNetworkThread(

new net::SdchOwner(context_->sdch_manager(), context_.get()));

if (json_pref_store_) {

sdch_owner_->EnablePersistentStorage(

- base::WrapUnique(new SdchOwnerPrefStorage(json_pref_store_.get())));

+ base::MakeUnique<SdchOwnerPrefStorage>(json_pref_store_.get()));

}

@@ -996,9 +996,9 @@ static void AddQuicHint(JNIEnv* env,

URLRequestContextConfig* config =

reinterpret_cast<URLRequestContextConfig*>(jurl_request_context_config);

config->quic_hints.push_back(

- base::WrapUnique(new URLRequestContextConfig::QuicHint(

+ base::MakeUnique<URLRequestContextConfig::QuicHint>(

base::android::ConvertJavaStringToUTF8(env, jhost), jport,

- jalternate_port)));

+ jalternate_port));

}

// Add a public key pin to URLRequestContextConfig.