Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Side by Side Diff: components/arc/arc_service_manager.cc

Issue 2257793002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/arc/bluetooth/arc_bluetooth_bridge.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/arc/arc_service_manager.h" 5 #include "components/arc/arc_service_manager.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/memory/ptr_util.h" 9 #include "base/memory/ptr_util.h"
10 #include "base/sequenced_task_runner.h" 10 #include "base/sequenced_task_runner.h"
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 g_arc_service_manager = this; 48 g_arc_service_manager = this;
49 49
50 if (g_arc_bridge_service_for_testing) { 50 if (g_arc_bridge_service_for_testing) {
51 arc_bridge_service_.reset(g_arc_bridge_service_for_testing); 51 arc_bridge_service_.reset(g_arc_bridge_service_for_testing);
52 g_arc_bridge_service_for_testing = nullptr; 52 g_arc_bridge_service_for_testing = nullptr;
53 } else { 53 } else {
54 arc_bridge_service_.reset(new ArcBridgeServiceImpl( 54 arc_bridge_service_.reset(new ArcBridgeServiceImpl(
55 ArcBridgeBootstrap::Create())); 55 ArcBridgeBootstrap::Create()));
56 } 56 }
57 57
58 AddService(base::WrapUnique(new ArcAudioBridge(arc_bridge_service()))); 58 AddService(base::MakeUnique<ArcAudioBridge>(arc_bridge_service()));
59 AddService(base::WrapUnique(new ArcBluetoothBridge(arc_bridge_service()))); 59 AddService(base::MakeUnique<ArcBluetoothBridge>(arc_bridge_service()));
60 AddService(base::WrapUnique(new ArcClipboardBridge(arc_bridge_service()))); 60 AddService(base::MakeUnique<ArcClipboardBridge>(arc_bridge_service()));
61 AddService( 61 AddService(base::MakeUnique<ArcCrashCollectorBridge>(arc_bridge_service()));
62 base::WrapUnique(new ArcCrashCollectorBridge(arc_bridge_service()))); 62 AddService(base::MakeUnique<ArcImeService>(arc_bridge_service()));
63 AddService(base::WrapUnique(new ArcImeService(arc_bridge_service()))); 63 AddService(base::MakeUnique<ArcMetricsService>(arc_bridge_service()));
64 AddService(base::WrapUnique(new ArcMetricsService(arc_bridge_service()))); 64 AddService(base::MakeUnique<ArcNetHostImpl>(arc_bridge_service()));
65 AddService(base::WrapUnique(new ArcNetHostImpl(arc_bridge_service()))); 65 AddService(base::MakeUnique<ArcObbMounterBridge>(arc_bridge_service()));
66 AddService(base::WrapUnique(new ArcObbMounterBridge(arc_bridge_service()))); 66 AddService(base::MakeUnique<ArcPowerBridge>(arc_bridge_service()));
67 AddService(base::WrapUnique(new ArcPowerBridge(arc_bridge_service()))); 67 AddService(base::MakeUnique<ArcStorageManager>(arc_bridge_service()));
68 AddService(base::WrapUnique(new ArcStorageManager(arc_bridge_service())));
69 } 68 }
70 69
71 ArcServiceManager::~ArcServiceManager() { 70 ArcServiceManager::~ArcServiceManager() {
72 DCHECK(thread_checker_.CalledOnValidThread()); 71 DCHECK(thread_checker_.CalledOnValidThread());
73 DCHECK(g_arc_service_manager == this); 72 DCHECK(g_arc_service_manager == this);
74 g_arc_service_manager = nullptr; 73 g_arc_service_manager = nullptr;
75 if (g_arc_bridge_service_for_testing) { 74 if (g_arc_bridge_service_for_testing) {
76 delete g_arc_bridge_service_for_testing; 75 delete g_arc_bridge_service_for_testing;
77 } 76 }
78 } 77 }
(...skipping 13 matching lines...) Expand all
92 void ArcServiceManager::AddService(std::unique_ptr<ArcService> service) { 91 void ArcServiceManager::AddService(std::unique_ptr<ArcService> service) {
93 DCHECK(thread_checker_.CalledOnValidThread()); 92 DCHECK(thread_checker_.CalledOnValidThread());
94 93
95 services_.emplace_back(std::move(service)); 94 services_.emplace_back(std::move(service));
96 } 95 }
97 96
98 void ArcServiceManager::OnPrimaryUserProfilePrepared( 97 void ArcServiceManager::OnPrimaryUserProfilePrepared(
99 const AccountId& account_id, 98 const AccountId& account_id,
100 std::unique_ptr<BooleanPrefMember> arc_enabled_pref) { 99 std::unique_ptr<BooleanPrefMember> arc_enabled_pref) {
101 DCHECK(thread_checker_.CalledOnValidThread()); 100 DCHECK(thread_checker_.CalledOnValidThread());
102 AddService(base::WrapUnique( 101 AddService(base::MakeUnique<ArcNotificationManager>(arc_bridge_service(),
103 new ArcNotificationManager(arc_bridge_service(), account_id))); 102 account_id));
104 } 103 }
105 104
106 void ArcServiceManager::Shutdown() { 105 void ArcServiceManager::Shutdown() {
107 icon_loader_ = nullptr; 106 icon_loader_ = nullptr;
108 activity_resolver_ = nullptr; 107 activity_resolver_ = nullptr;
109 services_.clear(); 108 services_.clear();
110 } 109 }
111 110
112 // static 111 // static
113 void ArcServiceManager::SetArcBridgeServiceForTesting( 112 void ArcServiceManager::SetArcBridgeServiceForTesting(
114 std::unique_ptr<ArcBridgeService> arc_bridge_service) { 113 std::unique_ptr<ArcBridgeService> arc_bridge_service) {
115 if (g_arc_bridge_service_for_testing) { 114 if (g_arc_bridge_service_for_testing) {
116 delete g_arc_bridge_service_for_testing; 115 delete g_arc_bridge_service_for_testing;
117 } 116 }
118 g_arc_bridge_service_for_testing = arc_bridge_service.release(); 117 g_arc_bridge_service_for_testing = arc_bridge_service.release();
119 } 118 }
120 119
121 } // namespace arc 120 } // namespace arc
OLDNEW
« no previous file with comments | « no previous file | components/arc/bluetooth/arc_bluetooth_bridge.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698