Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7080)

Unified Diff: chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm

Issue 2257743003: Add signal strength indicator icon to WebBluetooth chooser on Mac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bluetooth_signal_strength
Patch Set: address more comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm
diff --git a/chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm b/chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm
index 8ee3153f15e31f1827c92e1d4348503b6310a312..0072bf2d762edaea0b4fbcd946146c99578a45c5 100644
--- a/chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm
+++ b/chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm
@@ -188,10 +188,10 @@ std::unique_ptr<BubbleUi> ChooserBubbleDelegate::BuildBubbleUi() {
return [chooserContentView_ numberOfOptions];
}
-- (id)tableView:(NSTableView*)tableView
- objectValueForTableColumn:(NSTableColumn*)tableColumn
- row:(NSInteger)rowIndex {
- return [chooserContentView_ optionAtIndex:rowIndex];
+- (NSView*)tableView:(NSTableView*)tableView
+ viewForTableColumn:(NSTableColumn*)tableColumn
+ row:(NSInteger)rowIndex {
+ return [chooserContentView_ createTableRowView:rowIndex].autorelease();
}
- (BOOL)tableView:(NSTableView*)aTableView
@@ -200,6 +200,10 @@ std::unique_ptr<BubbleUi> ChooserBubbleDelegate::BuildBubbleUi() {
return NO;
}
+- (CGFloat)tableView:(NSTableView*)tableView heightOfRow:(NSInteger)row {
+ return [chooserContentView_ tableRowViewHeight:row];
+}
+
- (void)updateTableView {
[chooserContentView_ updateTableView];
}

Powered by Google App Engine
This is Rietveld 408576698