Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4086)

Unified Diff: chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller.mm

Issue 2257743003: Add signal strength indicator icon to WebBluetooth chooser on Mac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bluetooth_signal_strength
Patch Set: address more comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller.mm
diff --git a/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller.mm b/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller.mm
index 0ef8a21102df7851749edab6cdfbd56d9a0c83dd..f2f8a60162ebca8637d1ef9dd25205261e926495 100644
--- a/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller.mm
+++ b/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller.mm
@@ -45,10 +45,10 @@ initWithChooserDialogCocoa:(ChooserDialogCocoa*)chooserDialogCocoa
return [chooserContentView_ numberOfOptions];
}
-- (id)tableView:(NSTableView*)tableView
- objectValueForTableColumn:(NSTableColumn*)tableColumn
- row:(NSInteger)rowIndex {
- return [chooserContentView_ optionAtIndex:rowIndex];
+- (NSView*)tableView:(NSTableView*)tableView
+ viewForTableColumn:(NSTableColumn*)tableColumn
+ row:(NSInteger)rowIndex {
+ return [chooserContentView_ createTableRowView:rowIndex].autorelease();
}
- (BOOL)tableView:(NSTableView*)aTableView
@@ -57,6 +57,10 @@ initWithChooserDialogCocoa:(ChooserDialogCocoa*)chooserDialogCocoa
return NO;
}
+- (CGFloat)tableView:(NSTableView*)tableView heightOfRow:(NSInteger)row {
+ return [chooserContentView_ tableRowViewHeight:row];
+}
+
- (void)tableViewSelectionDidChange:(NSNotification*)aNotification {
[connectButton_ setEnabled:[tableView_ numberOfSelectedRows] > 0];
}

Powered by Google App Engine
This is Rietveld 408576698