third_party/WebKit/Source/web/tests/WebFrameTest.cpp - Issue 2257743002: Restore user state on ReloadwithoutSubResourceCacheRevalidation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Issue 2257743002: Restore user state on ReloadwithoutSubResourceCacheRevalidation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix webkit_unit_tests Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

index 914463ffe762c6ca0ed2198d2c850c74719a9632..a28fac48ada3c09273705f87ce4fd14bfbdb7f76 100644

--- a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

+++ b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

@@ -3262,6 +3262,8 @@ TEST_F(WebFrameTest, ReloadWithOverrideURLPreservesState)

webViewHelper.initializeAndLoad(m_baseURL + firstURL, true, &client);

webViewHelper.resize(WebSize(pageWidth, pageHeight));

webViewHelper.webView()->mainFrame()->setScrollOffset(WebSize(pageWidth / 4, pageHeight / 4));

+ // Ensure overview mode is disabled. Otherwise scale factor may be reset on reloads.

+ webViewHelper.webView()->settings()->setLoadWithOverviewMode(false);

webViewHelper.webView()->setPageScaleFactor(pageScaleFactor);

WebSize previousOffset = webViewHelper.webView()->mainFrame()->scrollOffset();

« third_party/WebKit/Source/core/loader/FrameLoader.cpp ('K') | « third_party/WebKit/Source/core/loader/FrameLoader.cpp ('k') | no next file » | no next file with comments »