android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java - Issue 2257743002: Restore user state on ReloadwithoutSubResourceCacheRevalidation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java

Issue 2257743002: Restore user state on ReloadwithoutSubResourceCacheRevalidation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: [rebase] Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java

index ed6ca7182f7d40d918fb2ac9c65a145a6b3c0eae..78a5e6507a3ace47ab1c3dd2e9c04825e993ac1c 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java

@@ -1350,15 +1350,20 @@ public class AwSettingsTest extends AwTestBase {

}

private String getData() {

+ // Add a sequence number as a comment to ensure WebView does not do

+ // something special for the same page load, for instance, restoring

+ // user state like a scroll position.

return "<html><head>"

+ (mWithViewPortTag ? "<meta name='viewport' content='width=3000' />" : "")

- + "</head>"

- + "<body></body></html>";

+ + "</head><body><!-- "

+ + mDataSequence++

+ + " --></body></html>";

}

private final boolean mWithViewPortTag;

private boolean mExpectScaleChange;

private int mOnScaleChangedCallCount;

+ private int mDataSequence;

}

class AwSettingsForceZeroLayoutHeightTestHelper extends AwSettingsTestHelper<Boolean> {

« no previous file with comments | « no previous file | content/child/runtime_features.cc » ('j') | no next file with comments »